GCP: GCP tarball is wrongly referenced in metadata

[yuqi-zhang]

Bug Report

Environment

RHCOS pipeline

Expected Behavior

Generates correct tarball

Actual Behavior

Generates incorrect tarball location

Reproduction Steps

Example failure: openshift/installer#2996

Other Information

Likely due to rework in 1dc3cdd where the reference names were changed

[cgwalters]

Taking this since I think @darkmuggle is travelling.

It seems to me we still have the dividing lines between cosa/mantle here aren't right - in this case, it's ore that's doing the upload, and knows the URL where the content can be found, but we're reconstructing that URL (in this case incorrectly) in cosa.

[miabbott]

Hmm...is this actually fixed?

The last known good build had the following:

"gcp": {
        "image": "rhcos-44-81-202001241431-0",
        "url": "https://storage.googleapis.com/rhcos/rhcos/44.81.202001241431.0.tar.gz"
    }

The next build that failed had:

"gcp": {
        "image": "rhcos-44-81-202001241932-0-gcp-x86-64",
        "url": "https://storage.googleapis.com/rhcos/rhcos/rhcos-44.81.202001241932.0-gcp.x86_64.tar.gz"
    }

And after #1079, I see:

"gcp": {
        "image": "rhcos-44-81-202001291108-0-gcp-x86-64",
        "url": "https://storage.googleapis.com/rhcos/rhcos/rhcos-44-81-202001291108-0-gcp-x86-64.tar.gz"
    }

[cgwalters]

What's wrong with the new one?

[yuqi-zhang]

In the rework we changed the naming schema. The problem was not the new name, but rather a disconnect between the new name of the actual tarball and the new name in the meta.json file

[miabbott]

I failed to notice the subtle changes of dots to dashes in the file name...sorry for the noise!