dracut: drop ignition-setup-user.service
#1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was removed in e2d3fa3.
It assumes that we can mount /dev/disk/by-label/boot and copy a file out of it, which may not be true on all distros. We already have a clear external API for providing injected user configs to Ignition (put them in /usr/lib/ignition/user.ign), so leave this to the distro to handle as it wishes.
This was referenced Jul 8, 2021
jlebon
approved these changes
Jul 8, 2021
|
CI requires coreos/fedora-coreos-config#1095. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It assumes that we can mount
/dev/disk/by-label/bootand copy a file out of it, which may not be true on all distros. We already have a clear external API for providing injected user configs to Ignition (put them in/usr/lib/ignition/user.ign), so leave this to the distro to handle as it wishes.