35coreos-ignition: move ignition-setup-user.service here
#1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream Ignition can't assume is-live-image exists, because the distro may not have provided it. But we know the coreos-live module is providing it, so drop the check.
The service contains distro-specific assumptions, so move it out of the upstream Ignition repo. This commit is a straight `cp`.
The fetch-offline stage now exists and runs before fetch, so update the dep. This shouldn't be a functional change.
This was referenced Jul 8, 2021
jlebon
approved these changes
Jul 9, 2021
| if is-live-image; then | ||
| # Live image. If the user has supplied a config.ign via an appended | ||
| # initrd, put it in the right place. | ||
| copy_file_if_exists "/config.ign" "${destination}/user.ign" |
There was a problem hiding this comment.
Hmm, I guess this bit could live in the live generator now. And then the service would be pulled in by diskful.target directly and e.g. we could hardcode the various Requires that are currently dynamic. OTOH, it's nice to have everything related to the Ignition config centralized, so... meh, maybe not worth it.
There was a problem hiding this comment.
Yeah, I'm on the fence too. Leaving alone for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service contains distro-specific assumptions, so move it out of the upstream Ignition repo.
coreos/ignition#1248 removes the service upstream. For more context, see coreos/ignition#1246 (comment).