Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: clean up /boot/ignition when done #1246

Closed
wants to merge 2 commits into from
Closed

dracut: clean up /boot/ignition when done #1246

wants to merge 2 commits into from

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jul 7, 2021

Avoid leaking an injected Ignition config into the real root once we're done with it.

For coreos/fedora-coreos-tracker#889. Requires coreos/fedora-coreos-config#1092.

bgilbert added 2 commits July 7, 2021 18:27
Avoid leaking an injected Ignition config into the real root once we're
done with it.

coreos/fedora-coreos-tracker#889
@jlebon
Copy link
Member

jlebon commented Jul 8, 2021

Hmm, IMO I think we should go the other way and remove ignition-setup-user.service from here:

  1. Out-of-band methods for passing Ignition configs is very distro-specific. Here for example, we're encoding the fact that the boot partition has label boot, which while a sensible label, is an odd thing to have Ignition dictate just so it can support a secondary input path.
  2. Mounting the boot partition, especially in read-write mode, is something that may require careful ordering and benefits greatly from distro centralization. I'd prefer having as few OS components as possible care about boot partitions so it's easier to manage at the integration level (right now for example in FCOS/RHCOS, we need a doc to keep track of it all).

That said, if we do decide to still keep it here, then I agree it'd make sense to have the deletion happen here too.

@bgilbert
Copy link
Contributor Author

bgilbert commented Jul 8, 2021

Yeah, I think that makes sense. I'll close this and post PRs to move ignition-setup-user.service out of this repo.

@bgilbert bgilbert closed this Jul 8, 2021
@bgilbert bgilbert deleted the cleanup branch July 8, 2021 18:49
@bgilbert
Copy link
Contributor Author

bgilbert commented Jul 8, 2021

ignition-setup-user.service removal in #1248.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants