Cirrus: Support testing with F31 #3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cevich
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
LGTM. The F31 packages will have to be tested with crun, not runc. Or we need to disable cgroupsV2. |
|
☔ The latest upstream changes (presumably #3728) made this pull request unmergeable. Please resolve the merge conflicts. |
Thanks, I half-guessed at this. I'm thinking we can drop the cgroupsv2/crun task, since having F31 in the mix will satisfy these neeeds. @giuseppe is that right, or is there reason to continue testing either on F30? |
openshift-ci-robot
added
the
needs-rebase
|
ewww, errr, crap |
cevich
force-pushed
the
support_f31
branch
2 times, most recently
from
66936df to
d578002
Compare
|
F31 VM setup packaging failures: |
|
All: Earliest working F31 cache-image build is (yes |
openshift-ci-robot
added
size/XL
and removed
needs-rebase
|
☔ The latest upstream changes (presumably #3817) made this pull request unmergeable. Please resolve the merge conflicts. |
cevich
changed the title
cevich
changed the title
Signed-off-by: Chris Evich <[email protected]>
The default scheduler is BFQ but integration tests run into https://bugzilla.redhat.com/show_bug.cgi?id=1767539 aka https://bugzilla.kernel.org/show_bug.cgi?id=205447 Using the deadline elevator as a workaround. Signed-off-by: Chris Evich <[email protected]>
In some distributions it's possible to have both runc and crun installed and/or for podman to be confused about which to use. In these instances, force the decision by adding `OCI_RUNTIME=/usr/bin/crun` into `/etc/environment`. Also in-place modify libpod.conf to use 'crun' instead of 'runc' Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Sometime between 10th and 23rd of Feb. 2020, the behavior of crun changed. Upon consulting with Giuseppe, the podman run tests for `device-read-*` and `device-write-*` do not depend on the container output for success, only the exit code. Add a comment and conditional regarding this in case of cgroupsv2. Also noted that these tests will likely require future refactoring/simplification. Signed-off-by: Chris Evich <[email protected]>
Recommended as part of: containers#5004 and containers/crun#230 Signed-off-by: Chris Evich <[email protected]>
It's possible/likely the container image for the test will need to be pulled as part of the `run` command. Due to the way BATS handles output, messages regarding image-pull could be misinterpreted as the container's CID. Force the CID to be obtained by only the last line of output. Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add F31 + Drop F29
Depends on: #3754 #4028 #4028 #4154 #4222 #4825
Fixes #5285
Fixes #3447
Signed-off-by: Chris Evich [email protected]