Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Show names/versions of critical packages #4154

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Sep 30, 2019

Signed-off-by: Chris Evich [email protected]

@cevich cevich force-pushed the show_packages branch 2 times, most recently from a10e02b to d209020 Compare September 30, 2019 22:04
fedora*)
PKG_LST_CMD='rpm -q --qf=%{N}-%{V}-%{R}-%{ARCH}\n'
PKG_NAMES=(\
container-selinux \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come the list of packages is different between fedora and ubuntu?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally different packaging systems for one, the Ubuntu packages come from the PPA that @lsm5 robots maintain. Though TBH the lists here are somewhat arbitrary...I grabbed them from contrib/cirrus/packer/{fedora,ubuntu}_setup.sh. Happy to add/change/remove packages to log here, or in a followup PR. Any suggestions?

Adds an output to all testing tasks which lists the names/versions of
critical/essential packages present on the VM.

Signed-off-by: Chris Evich <[email protected]>
@cevich
Copy link
Member Author

cevich commented Oct 1, 2019

The new output shows up in the CirrusCI WebUI for all the 'testing' tasks:

screenshot

@mheon
Copy link
Member

mheon commented Oct 1, 2019

/approve
LGTM

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2019
@rhatdan
Copy link
Member

rhatdan commented Oct 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7e47abe into containers:master Oct 1, 2019
@cevich cevich deleted the show_packages branch June 30, 2021 18:12
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants