Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Produce and collect varlink output #4222

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Cirrus: Produce and collect varlink output #4222

merged 1 commit into from
Oct 9, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Oct 8, 2019

When executing 'make remotesystem' testing, a varlink process is started
up but it's stdio is dumped due to the production of excessive data.
However, this also means if the process has a problem, any errors will
not be accessible.

Instead, grab only the last 100 lines and direct them into a file. Also
update automation's log collection to retrieve this file when the
$REMOTE_CLIENT env. var. is true.

Signed-off-by: Chris Evich [email protected]

@cevich
Copy link
Member Author

cevich commented Oct 8, 2019

@edsantiago PTAL when u have a mo. I believe I got the redirect correct. Not sure I'm happy about the collection condition, but want to let the tests run to see how it works out...

@cevich cevich changed the title Cirrus: Produce and collect varlink output WIP: Cirrus: Produce and collect varlink output Oct 8, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2019
edsantiago
edsantiago reviewed Oct 8, 2019
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits. Mostly LGTM, thank you for catching this.

Makefile Outdated Show resolved Hide resolved
contrib/cirrus/logcollector.sh Outdated Show resolved Hide resolved
contrib/cirrus/logcollector.sh Outdated Show resolved Hide resolved
@cevich cevich force-pushed the collect_varlink_log branch from 2652b27 to 10a2c6e Compare October 8, 2019 20:05
edsantiago
edsantiago approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The conditional in the Makefile is scary but I guess a good idea to avoid leaving logs on dev systems.

@cevich
Cirrus: Produce and collect varlink output
ffe726e 
When executing 'make remotesystem' testing, a varlink process is started
up but it's stdio is dumped due to the production of excessive data.
However, this also means if the process has a problem, any errors will
not be accessible.

Instead, grab only the last 100 lines and direct them into a file.  Also
update automation's log collection to retrieve this file when the
`$REMOTE_CLIENT` env. var. is `true`.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich force-pushed the collect_varlink_log branch from 10a2c6e to ffe726e Compare October 8, 2019 20:47
@cevich cevich changed the title WIP: Cirrus: Produce and collect varlink output Cirrus: Produce and collect varlink output Oct 8, 2019
@cevich
Copy link
Member Author

cevich commented Oct 8, 2019

Thanks for the collaboration @edsantiago I think I've got all the tweaks and suggestions packaged up, hopefully tests will show this working...

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2019
@cevich cevich mentioned this pull request Oct 8, 2019
Merged
@edsantiago
Copy link
Member

Tests pass (after the usual re-run of flakes). I see varlink.log in some runs, also see "no such file or directory" in others. What I don't see is failures in podman-varlink not running :-(

@cevich
Copy link
Member Author

cevich commented Oct 9, 2019

What I don't see is failures in podman-varlink not running :-(

@edsantiago that's okay, I've only seen that in #3901 under the new F31 (beta) VM. Once this merges I'll rebase that and hopefully we'll catch something useful.

@mheon
Copy link
Member

mheon commented Oct 9, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2019
@mheon
Copy link
Member

mheon commented Oct 9, 2019

Changes LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 2bf184a into containers:master Oct 9, 2019
@cevich cevich deleted the collect_varlink_log branch June 30, 2021 18:04
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cevich @edsantiago @mheon @openshift-ci-robot @rhatdan @openshift-merge-robot