Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sys] kube play read-only: racy status checks #18047

Closed
edsantiago opened this issue Apr 4, 2023 · 2 comments · Fixed by #18169
Closed

[sys] kube play read-only: racy status checks #18047

edsantiago opened this issue Apr 4, 2023 · 2 comments · Fixed by #18169
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Flake seen in my hammer-sqlite PR, f37 aarch64 root, both local and remote:

not ok 535 podman kube play read-only from containers.conf
...
# podman inspect --format {{.State.ExitCode}} pod1-test2
0
#/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
#|     FAIL: Container / should be read/only   <---- poor message. Should read "exit status from touch /file on RO container"
#| expected: '1'
#|   actual: '0'

Root cause: when podman kube play runs containers, a container that exits nonzero seems to be infinite-looped: it keeps retrying forever. The above inspect caught it in a moment when the container had just started.

Solution: I give up. I've spent an hour trying to play with restartPolicy and container create --restart=no (which does not get seen by podman generate kube) and looking at man pages. I can find no way to tell podman-kube to just run that container once.

I'm astonished that this doesn't flake more often.

@edsantiago edsantiago added flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. labels Apr 4, 2023
@rhatdan
Copy link
Member

rhatdan commented Apr 4, 2023

@umohnani8 PTAL

@edsantiago
Copy link
Member Author

One of our most popular flakes this week. I'm hoping #17627 will let me find a way to fix this.

edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 12, 2023
Use --restart=no on all created containers. Without this, all
containers spin forever and it's impossible to get a
reliable exit status.

As a side effort, clean up tests, make more robust and maintainable.

Fixes: containers#18047

Signed-off-by: Ed Santiago <[email protected]>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants