api: auth: fix nil deref #18143
Merged
api: auth: fix nil deref #18143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Fix has been merged into common. I will wait with merging this one until after the vendor dance. |
By pulling in the fixes from c/common. Add regression tests to make sure it's not happening another time. The error messages are not ideal and should probably be optimized in the `/auth` endpoints directly but it's already an improvement over a nil deref. Signed-off-by: Valentin Rothberg <[email protected]>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Ready to go. @containers/podman-maintainers PTAL |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel Good to go since we have |
openshift-ci
bot
removed
the
do-not-merge/hold
This was referenced Apr 12, 2023
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By pulling in the fixes from c/common. Add regression tests to make sure it's not happening another time. The error messages are not ideal and should probably be optimized in the
/authendpoints directly but it's already an improvement over a nil deref.Does this PR introduce a user-facing change?