-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: enable sqlite system tests #17954
CI: enable sqlite system tests #17954
Conversation
c165b2e
to
8b43963
Compare
heads-up, github CI reporting seems to be stalled. Job is done, all green, but as of the moment I write this github is still showing jobs queued. |
@cevich this job finished (green) many hours ago. Is there any way to tell Github to catch up, or do we have to resubmit all jobs? |
Whoa, that's weird. I don't remember ever seeing that behavior before. Looking at the timer, it's going on 6-hours, so I'd bet it will never be marked as completed. Since clearly they're all green, I would just ask for this to be manually merged. Unless you think re-running would be faster 😞 |
I don't mind repushing - this is a scary PR, and more testing is good. It's just, all PRs from this morning are stuck because of the github hiccup. I was wondering if there was a fix. |
8b43963
to
678af68
Compare
Blocked by #17904 |
d940c9f
to
8d81445
Compare
f01edea
to
cd917d6
Compare
5f4c1ca
to
3204f99
Compare
6cda2f3
to
fe5855f
Compare
In setup, write a containers.conf.d file with db_backend as specified in .cirrus.yml. This is actually much scarier and more achy-breaky than merely "sqlite system tests": it enables sqlite in e2e tests. ("But wait, we already do that!" -- no, not really. sqlite in e2e is being done via --db-backend option, and some podman commands in e2e do not use the standard options. See containers#17904. This is unlikely to get merged any time soon (March, maybe even April) because sqlite is still too fragile; this will trigger more flakes than are currently acceptable. Also, the nasty auto-update flake seems to trigger much more reliably with sqlite. We need that one fixed. Signed-off-by: Ed Santiago <[email protected]>
fe5855f
to
f95276b
Compare
@cevich @containers/podman-maintainers this is ready to go. I hand-checked all logs, all flakes are the usual ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Waiting for a head nod from @cevich
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/hold cancel |
In setup, write a containers.conf.d file with db_backend
as specified in .cirrus.yml.
This is actually much scarier and more achy-breaky than
merely "sqlite system tests": it enables sqlite in e2e
tests. ("But wait, we already do that!" -- no, not really.
sqlite in e2e is being done via --db-backend option, and
some podman commands in e2e do not use the standard options.
See #17904.
This is unlikely to get merged any time soon (March, maybe
even April) because sqlite is still too fragile; this will
trigger more flakes than are currently acceptable. Also,
the nasty auto-update flake seems to trigger much more
reliably with sqlite. We need that one fixed.
Signed-off-by: Ed Santiago [email protected]