Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on max_wasm_code_size #239

Closed
webmaster128 opened this issue Jan 21, 2022 · 6 comments · Fixed by #361
Closed

Decide on max_wasm_code_size #239

webmaster128 opened this issue Jan 21, 2022 · 6 comments · Fixed by #361
Labels
S Small, <1 day work

Comments

@webmaster128
Copy link
Member

Traditionally we used 600 KiB which was changed to 1200 KiB in CosmWasm/wasmd#550. I am not aware of any testing or analysis what the implications of this new value is. It now made it into Tgrade.

I think we should double check if 1200 KiB is really the value we want to offer in the first version of Tgrade. Those magabytes we will have to carry around for a long time and it will be very hard to decrease the limit later on.

Terra is talking about increasing the limit from 600 -> 1200 but the arguments don't seem to be very convincing on both sides:

@alpe alpe added the S Small, <1 day work label Jan 28, 2022
@alpe alpe added this to the Tgrade 0.8 - "Mainnet" milestone Feb 15, 2022
@daniellarita
Copy link

@webmaster128 @migmeneses do you have some final opinions on what size we should use?

@webmaster128
Copy link
Member Author

Let's use 777 KiB until we have a better clue.

@migmeneses
Copy link

dryrunnet has max_wasm_code_size of:
"max_wasm_code_size": "1228800"

@webmaster128
Copy link
Member Author

I would stay well below 1MB as this is not needed right now and sinces above 600-800KB are not well tested.

@webmaster128
Copy link
Member Author

Looking at the changes in CosmWasm/wasmd#826, I suggest using the default from wasmd unless we have a very good reason to change it. The value is not needed in genesis anymore.

@alpe
Copy link
Contributor

alpe commented May 10, 2022

I was about to suggest the same. I will close this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S Small, <1 day work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants