-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on max_wasm_code_size #239
Comments
@webmaster128 @migmeneses do you have some final opinions on what size we should use? |
Let's use 777 KiB until we have a better clue. |
dryrunnet has max_wasm_code_size of: |
I would stay well below 1MB as this is not needed right now and sinces above 600-800KB are not well tested. |
Looking at the changes in CosmWasm/wasmd#826, I suggest using the default from wasmd unless we have a very good reason to change it. The value is not needed in genesis anymore. |
I was about to suggest the same. I will close this now |
Traditionally we used 600 KiB which was changed to 1200 KiB in CosmWasm/wasmd#550. I am not aware of any testing or analysis what the implications of this new value is. It now made it into Tgrade.
I think we should double check if 1200 KiB is really the value we want to offer in the first version of Tgrade. Those magabytes we will have to carry around for a long time and it will be very hard to decrease the limit later on.
Terra is talking about increasing the limit from 600 -> 1200 but the arguments don't seem to be very convincing on both sides:
The text was updated successfully, but these errors were encountered: