Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmd v0.27.0-rc0 integration #361

Merged
merged 2 commits into from
May 11, 2022
Merged

Wasmd v0.27.0-rc0 integration #361

merged 2 commits into from
May 11, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented May 9, 2022

Adds

  • Statesync
  • Interchain accounts (host role)
  • Wasmd v0.27

@alpe alpe requested a review from ethanfrey May 9, 2022 14:19
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #361 (c6c543d) into main (828c97f) will increase coverage by 0.10%.
The diff coverage is 81.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
+ Coverage   57.66%   57.76%   +0.10%     
==========================================
  Files          73       73              
  Lines        5447     5479      +32     
==========================================
+ Hits         3141     3165      +24     
- Misses       1994     2000       +6     
- Partials      312      314       +2     
Impacted Files Coverage Δ
app/test_access.go 0.00% <ø> (ø)
x/poe/keeper/historical_info.go 91.30% <ø> (ø)
x/twasm/contract/incoming_msgs.go 85.10% <ø> (ø)
app/ante.go 51.21% <33.33%> (-2.63%) ⬇️
app/app.go 87.26% <85.00%> (-0.65%) ⬇️

Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to match with v0.27.0-rc0.

It would be nice to

  1. merge open wasmd PR
  2. tag wasmd v0.27.0-rc2
  3. update this to use that (and ICA controller)

before merging this. I assume -rc2 will basically be the final version.

Also, I didn't see the code where you modify the max wasm size constant. I was assuming you would set that global constant from x/wasm in app.go, but maybe you did it somewhere else and I missed it.

app/ante.go Show resolved Hide resolved
@@ -179,12 +186,14 @@ type TgradeApp struct {
ibcKeeper *ibckeeper.Keeper // IBC Keeper must be a pointer in the app, so we can SetRouter on it correctly
evidenceKeeper evidencekeeper.Keeper
transferKeeper ibctransferkeeper.Keeper
icaHostKeeper icahostkeeper.Keeper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once wasmd #848 is merged, you can add controller functionality as well

app/app.go Show resolved Hide resolved
@alpe
Copy link
Contributor Author

alpe commented May 10, 2022

I was assuming you would set that global constant ..

We go with the new wasmd default #239 . I have updated the description for this PR

@alpe alpe mentioned this pull request May 11, 2022
@alpe alpe changed the title Wasmd v0.27 integration Wasmd v0.27.0-rc0 integration May 11, 2022
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in, and update to the v0.27.0 when that is out.

@ethanfrey ethanfrey merged commit dd246b4 into main May 11, 2022
@ethanfrey ethanfrey deleted the wasmd027 branch May 11, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on max_wasm_code_size
3 participants