-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasmd v0.27.0-rc0 integration #361
Conversation
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 57.66% 57.76% +0.10%
==========================================
Files 73 73
Lines 5447 5479 +32
==========================================
+ Hits 3141 3165 +24
- Misses 1994 2000 +6
- Partials 312 314 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to match with v0.27.0-rc0.
It would be nice to
- merge open wasmd PR
- tag wasmd v0.27.0-rc2
- update this to use that (and ICA controller)
before merging this. I assume -rc2 will basically be the final version.
Also, I didn't see the code where you modify the max wasm size constant. I was assuming you would set that global constant from x/wasm in app.go, but maybe you did it somewhere else and I missed it.
@@ -179,12 +186,14 @@ type TgradeApp struct { | |||
ibcKeeper *ibckeeper.Keeper // IBC Keeper must be a pointer in the app, so we can SetRouter on it correctly | |||
evidenceKeeper evidencekeeper.Keeper | |||
transferKeeper ibctransferkeeper.Keeper | |||
icaHostKeeper icahostkeeper.Keeper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once wasmd #848 is merged, you can add controller functionality as well
We go with the new wasmd default #239 . I have updated the description for this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in, and update to the v0.27.0 when that is out.
Adds