-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate MaxWasmSize constraints into a single var #826
Conversation
Also removes redundant maxWasmSize param
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
==========================================
- Coverage 59.37% 59.32% -0.06%
==========================================
Files 51 51
Lines 5898 5883 -15
==========================================
- Hits 3502 3490 -12
+ Misses 2144 2142 -2
+ Partials 252 251 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for nudging it over the line while I was indisposed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
I'm worried that this could break existing chains without a state migration: remove an existing param from ParamSetPairs table, removing field from protobuf.
See an example of adding a new param key https://github.com/cosmos/cosmos-sdk/blob/main/x/staking/migrations/v046/store.go#L21 Do we need to add such migration to remove it ? |
@jhernandezb Good questions! As far as breaking changes go, I think the only time you'd experience breaking behavior is if your param was set to a value lower than the 500KB that was defined as a constant in the validation section. The old param not being present shouldn't break anything, but I do agree it would be tidier to write a migration to remove it from the store, as it certainly won't be used anymore. |
I'll add an upgrade test to our chain code targeting this branch and see how it goes. |
Resolves #813
This PR contains all work started in #809 by @bigs rebased on top of current main.
Big thanks for the contribution and driving this forward! 💐
Note: with this PR the max code size was changed from 500kb to 800kb