Consolidate MaxWasmSize constraints into a single var

[alpe]

Resolves #813

This PR contains all work started in #809 by @bigs rebased on top of current main.
Big thanks for the contribution and driving this forward! 💐

Note: with this PR the max code size was changed from 500kb to 800kb

[codecov]

Codecov Report

Merging #826 (3b573eb) into main (8ca55b7) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
- Coverage   59.37%   59.32%   -0.06%     
==========================================
  Files          51       51              
  Lines        5898     5883      -15     
==========================================
- Hits         3502     3490      -12     
+ Misses       2144     2142       -2     
+ Partials      252      251       -1     

Impacted Files	Coverage Δ
x/wasm/types/params.go	60.21% <ø> (-1.33%)	⬇️
x/wasm/types/validation.go	100.00% <ø> (ø)
x/wasm/keeper/keeper.go	87.74% <100.00%> (-0.09%)	⬇️

[bigs]

This looks great, thanks for nudging it over the line while I was indisposed!

[pinosu]

lgtm 👍

[jhernandezb]

I'm worried that this could break existing chains without a state migration: remove an existing param from ParamSetPairs table, removing field from protobuf.

• What will happen when chains upgrade and params are retrieved? will ignore the previous existence of the param or fail?
• What will happen to a chain data export ?

See an example of adding a new param key https://github.com/cosmos/cosmos-sdk/blob/main/x/staking/migrations/v046/store.go#L21

Do we need to add such migration to remove it ?

[bigs]

@jhernandezb Good questions! As far as breaking changes go, I think the only time you'd experience breaking behavior is if your param was set to a value lower than the 500KB that was defined as a constant in the validation section.

The old param not being present shouldn't break anything, but I do agree it would be tidier to write a migration to remove it from the store, as it certainly won't be used anymore.

[jhernandezb]

I'll add an upgrade test to our chain code targeting this branch and see how it goes.