Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiply default wasm size by 2 #550

Merged
merged 2 commits into from
Jul 5, 2021
Merged

Multiply default wasm size by 2 #550

merged 2 commits into from
Jul 5, 2021

Conversation

orkunkl
Copy link
Contributor

@orkunkl orkunkl commented Jul 2, 2021

On testnets, we multiply this limit by 2. In the past we have seen contracts exceeding this limit. We can increase this by default if you see fit.

@orkunkl orkunkl requested a review from alpe July 2, 2021 08:54
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #550 (85b338a) into master (d2e35c2) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
- Coverage   58.71%   58.67%   -0.05%     
==========================================
  Files          43       43              
  Lines        4508     4508              
==========================================
- Hits         2647     2645       -2     
- Misses       1644     1645       +1     
- Partials      217      218       +1     
Impacted Files Coverage Δ
x/wasm/types/params.go 61.44% <ø> (ø)
x/wasm/keeper/keeper.go 84.63% <0.00%> (-0.44%) ⬇️

@alpe
Copy link
Contributor

alpe commented Jul 5, 2021

Good feedback! 💐

@alpe alpe merged commit 273b57a into master Jul 5, 2021
@alpe alpe deleted the increase-default-wasm-size branch July 5, 2021 09:00
@ethanfrey
Copy link
Member

1.2MB is big. But we have been hitting it in the past. Especially any contract that brings their own crypto (inside wasm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants