Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pip check to recipe tests #5099

Merged
merged 4 commits into from
Dec 6, 2023
Merged

add pip check to recipe tests #5099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bcdcdc
add pip check to recipe tests
dholth Dec 6, 2023
ff06d9a
add pip to test requires
dholth Dec 6, 2023
e7f572b
update recipe
dholth Dec 6, 2023
c0b8ca5
conda packgae has no pip metadata; remove pyproject lief dependency
dholth Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ dependencies = [
"jinja2",
"jsonschema >=4.19",
"libarchive-c",
"lief",
kenodegard marked this conversation as resolved.
Show resolved Hide resolved
"menuinst",
"packaging",
"pkginfo",
Expand Down
4 changes: 4 additions & 0 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,13 @@ test:
- conda_build
# new/updated submodules (can be dropped after 1-2 releases)
- conda_build.index
requires:
- setuptools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird to me. Is it because pip check complains that setuptools isn't present?

Copy link
Contributor Author

@dholth dholth Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools was in the other version of the recipe/feedstock. Maybe for - test_bdist_conda_setup.py. Not related to pip check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copied over from the AnacondaRecipes conda-build-feedstock where it was originally added in AnacondaRecipes/conda-build-feedstock#26, not sure why

- pip
files:
- test_bdist_conda_setup.py
commands:
- python -m pip check
# builtin subcommands
- conda --help
- conda build --help
Expand Down
Loading