add pip check to recipe tests #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
kenodegard
reviewed
Dec 6, 2023
kenodegard
reviewed
Dec 6, 2023
kenodegard
previously approved these changes
Dec 6, 2023
kenodegard
reviewed
Dec 6, 2023
Review build status
Once it's done, use this command to try it out in a new conda environment:
|
kenodegard
approved these changes
Dec 6, 2023
| @@ -61,9 +61,13 @@ test: | |||
| - conda_build | |||
| # new/updated submodules (can be dropped after 1-2 releases) | |||
| - conda_build.index | |||
| requires: | |||
| - setuptools | |||
There was a problem hiding this comment.
This feels weird to me. Is it because pip check complains that setuptools isn't present?
There was a problem hiding this comment.
setuptools was in the other version of the recipe/feedstock. Maybe for - test_bdist_conda_setup.py. Not related to pip check.
There was a problem hiding this comment.
this is copied over from the AnacondaRecipes conda-build-feedstock where it was originally added in AnacondaRecipes/conda-build-feedstock#26, not sure why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
lief was added to the pip-style dependencies, causing pip check to fail since py-lief's conda package has no
dist-info(pip metadata)Xref #5101
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?