Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 3.25.0 #26

Merged
merged 5 commits into from
May 25, 2023
Merged

Bump version to 3.25.0 #26

merged 5 commits into from
May 25, 2023

Conversation

kenodegard
Copy link

Changelog: https://github.com/conda/conda-build/blob/3.25.0/CHANGELOG.md
Requirements: https://github.com/conda/conda-build/blob/3.25.0/pyproject.toml

Additional changes:

@kenodegard kenodegard self-assigned this May 24, 2023
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:28: patch_unnecessary: patch should not be in build when source/patches is not set
ERROR: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:32: no_git_on_windows: git should not be used as a dependency on Windows.
ERROR: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:37: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:50: build_tools_must_be_in_build: The build tool m2-patch is not in the build section.
WARNING: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:50: build_tools_must_be_in_build: The build tool patch is not in the build section.
WARNING: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:51: python_build_tool_in_run: The python build tool packaging is in run depends
ERROR: /tmp/abs_2db69fpdrn/clone/recipe/meta.yaml:91: missing_pip_check: For pypi packages, pip check should be present in the test commands
Errors were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_03yjgw3cz1/clone/recipe/meta.yaml:28: patch_unnecessary: patch should not be in build when source/patches is not set
ERROR: /tmp/abs_03yjgw3cz1/clone/recipe/meta.yaml:32: no_git_on_windows: git should not be used as a dependency on Windows.
WARNING: /tmp/abs_03yjgw3cz1/clone/recipe/meta.yaml:51: build_tools_must_be_in_build: The build tool patch is not in the build section.
WARNING: /tmp/abs_03yjgw3cz1/clone/recipe/meta.yaml:51: build_tools_must_be_in_build: The build tool m2-patch is not in the build section.
Errors were found

@kenodegard kenodegard mentioned this pull request May 24, 2023
20 tasks
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_c3r6xsaqoj/clone/recipe/meta.yaml:28: patch_unnecessary: patch should not be in build when source/patches is not set
Errors were found

@skupr-anaconda
Copy link

The git conda package shouldn't be used in build on win-64. The build workers have cygwin git already installed so it is not necessary.

Any usage of git should be replaced with git # [not win], see anaconda/anaconda-linter#189 (comment)

Copy link

@skupr-anaconda skupr-anaconda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kenodegard kenodegard merged commit 2141f7c into master May 25, 2023
@kenodegard kenodegard deleted the default-3.25.0 branch May 25, 2023 14:47
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_3ew0niox42/clone/recipe/meta.yaml:28: patch_unnecessary: patch should not be in build when source/patches is not set
Errors were found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants