Added recipe for kwant #1446

basnijholt · 2016-08-31T11:41:36Z

Depends on the following pull requests:

tinyarray Add recipe for tinyarray #1444
metis Create recipe for metis #1442
mumps Add recipe for mumps #1445
scotch Added recipe for scotch #1427

conda-forge-linter · 2016-08-31T11:41:41Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kwant) and found some lint.

Here's what I've got...

For recipes/kwant:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

basnijholt · 2016-08-31T11:45:21Z

@jakirkham could you give me advice on the following part:

requirements:
  build:
    - gcc
    - openblas  # [linux]
  run:
    - openblas  # [linux]
    - libgcc
    - libgfortran  # [linux]

Should I swap gcc with toolchain and omit libgcc? And what about openblas and gfortran`?

basnijholt · 2016-08-31T11:54:03Z

For recipes/kwant:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

@pelson @msarahan any idea why this can have happened? This is the meta.yaml

Edit: This is fixed now, thanks to @ocefpaf.

ocefpaf · 2016-08-31T12:10:53Z

recipes/kwant/meta.yaml

+
+package:
+  name: {{ name }}
+  version: "1.2.2" [py3k]


The linter is choking here. You can lint a recipe locally with conda smithy recipe-lint.

conda-forge-linter · 2016-08-31T12:23:03Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kwant) and found it was in an excellent condition.

jakirkham · 2016-08-31T13:15:51Z

recipes/kwant/meta.yaml

+requirements:
+  build:
+    - python
+    - gcc


Please use toolchain instead.

jakirkham · 2016-08-31T13:19:00Z

FWICT this is Python, C, and C++. However there is not Fortran that I can see. The following suggestions should be fine.

Also does this link to a BLAS directly? If so, mimic our NumPy recipe w.r.t. OpenBLAS.

basnijholt · 2016-08-31T13:34:12Z

There's no fortran code in kwant itself. However, we link against mumps, which is a fortran library. So usually you'd also have to link against libgfortran.

Also the package on my channel doesn't work without gfortran. Are there differences for packages compiled by myself and conda-forge?

basnijholt · 2016-08-31T14:40:29Z

Also does this link to a BLAS directly? If so, mimic our NumPy recipe w.r.t. OpenBLAS.

Yes, kwant directly links to BLAS, because it uses LAPACK. I'll take a look at the numpy recipe.

basnijholt · 2016-08-31T14:56:53Z

@jakirkham you mean that I should add:

  features:
    - blas_openblas  # [linux]

as I did here.

However, in the numpy recipe I also see - blas 1.1 openblas. Don't know what it's for, but should I include that as well?

Another thing, why is OpenBLAS also added for Mac OSX, I thought this wasn't needed?

jakirkham · 2016-11-01T12:08:20Z

recipes/kwant/meta.yaml

+
+about:
+  home: http://kwant-project.org/
+  license: BSD 2-Clause


Could optionally add license_family: BSD.

Done below.

basnijholt · 2016-11-01T14:59:44Z

Are all of these needed at build time or can some of them be dropped (e.g. matplotlib, scipy, etc.)?

@jakirkham I have enumerated them all, and the current build requirements are all needed (I removed matplotlib.)

jakirkham · 2016-11-02T16:09:56Z

recipes/kwant/meta.yaml

+package:
+  name: {{ name }}
+  version: {{ py3k_ver }}  # [py3k]
+  version: {{ py2k_ver }}  # [py2k]


Why do we have 2 different versions? Could we not just start with 1.1.2 and then drop Python 2.x support when upgrading or is there more going on here?

Development for Python 2 stopped, however, bug fixes will still be applied. So the version number for both Python 2 and 3 will change, but not won't be the same.

So the typical solution for this is to start with the oldest version that you wish to have in the feedstock (guessing 1.1.2). Then update master to the latest versions (and any other relevant ones inbetween on the way). Then the old support version (guessing 1.1.x) can be a new branch say 1.1 and will just track patch releases for that.

Changed to only Python 2 in f32eb41.

jakirkham · 2016-11-02T16:10:37Z

recipes/kwant/meta.yaml

+    - nose
+    - tinyarray
+    - libgfortran
+    - libgcc


I suspect we only need one of these. Maybe just libgfortran, but please let me know if there is more going on (e.g. is there C++?).

They are both needed I think, see this build of this commit 471c711

I see. So it does need C++.

Please add yum_requirements.txt with devtoolset-2-gcc-gfortran. Also please add a selector to use gcc on OS X only. Then please add export LIBRARY_PATH="${PREFIX}/lib" to build.sh. Finally please drop libgcc, but keep/add libgfortran (in build and run).

This strategy is used for scipy, hdf5, and other C/C++/Fortran libraries of note.

xref: conda-forge/scipy-feedstock#2
xref: conda-forge/scipy-feedstock#3

I did what you suggested, but still getting this error: ImportError: /usr/lib64/libstdc++.so.6: version GLIBCXX_3.4.15' not found (required by /opt/conda/envs/_test/lib/python2.7/site-packages/kwant/graph/slicer.so). I have added export LD_LIBRARY_PATH="${PREFIX}/lib"tobuid.sh`.

Adding LD_LIBRARY_PATH alone didn't help, still the same error message.

jakirkham · 2016-11-02T17:48:06Z

recipes/kwant/meta.yaml

+
+build:
+  skip: true  # [win]
+  skip: true  # [py3k] 


These can be combined skip: true # [win or py3k].

~~Also is it that this version is Python 2 only or is it that this version is the last one that supports Python 2, but also supports Python 3?~~ Nevermind answered my own question.

Fixed in 82ea10c. There is no version that combines both Python 2 and 3 simultaneously.

conda-forge-linter · 2016-11-02T17:49:41Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kwant) and found some lint.

Here's what I've got...

For recipes/kwant:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form.

jakirkham · 2016-11-02T17:50:17Z

recipes/kwant/meta.yaml

+    - blas 1.1 {{ variant }}
+    - openblas 0.2.18|0.2.18.*
+    - mumps
+    - numpy


Is it linking to numpy? If so, this needs to be numpy x.x.

Yes, it is linking to numpy. Fixed in e2bb0c2.

jakirkham · 2016-11-02T17:50:23Z

recipes/kwant/meta.yaml

+    - blas 1.1 {{ variant }}
+    - openblas 0.2.18|0.2.18.*
+    - mumps
+    - numpy


Same as above.

Fixed in e2bb0c2

jakirkham · 2016-11-02T17:51:20Z

Also please add [skip appveyor] to commit messages as this does not build on Windows.

conda-forge-linter · 2016-11-02T17:52:51Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kwant) and found it was in an excellent condition.

jakirkham · 2016-11-02T17:54:04Z

So I think you have CircleCI enabled on your fork of staged-recipes. Could you please disable it? Seems to be getting in the way of running it here at staged-recipes.

basnijholt · 2016-11-02T17:55:52Z

I stopped it :-)

jakirkham · 2016-11-02T18:13:11Z

Toggling to get CircleCI to restart on staged-recipes ( hopefully 🍀 ).

jakirkham · 2016-11-02T18:13:55Z

Seems to have worked. 😄

basnijholt · 2016-11-03T10:53:16Z

And also the builds are passing 👍

jakirkham · 2016-11-03T13:41:43Z

Thanks @basnijholt .

Added recipe for kwant

da9a736

Add newline to meta.yaml

4892d0b

ocefpaf reviewed Aug 31, 2016
View reviewed changes

Change in meta.yaml, fix linter issue, thanks to @ocefpaf

88c4872

basnijholt added 3 commits August 31, 2016 14:40

Change BSD to BSD 2-Clause

923fa2a

Correct urls

9d76e77

Specify version for Python 2 and 3

52272b3

jakirkham reviewed Aug 31, 2016
View reviewed changes

recipes/kwant/meta.yaml

requirements:

build:

- python

- gcc

Copy link

Member

jakirkham Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use toolchain instead.

gcc -> toolchain and drop libgcc

5f9b71f

Add features: - blas_openblas

812837a

basnijholt mentioned this pull request Sep 3, 2016

Create recipe for metis #1442

Merged

basnijholt added 3 commits October 3, 2016 11:43

Fix sha256

03ff686

sed the prefix

4b25da3

Add openblas for OSX

aeb7251

basnijholt mentioned this pull request Oct 10, 2016

Add recipe for discretizer #1747

Merged

5 tasks

basnijholt added 4 commits October 17, 2016 09:38

change to mumps and fix openblas pinning

1507550

remove accidental dot after openblas pinning

25887d2

Add extra_link_args = -Wl,-rpath,PREFIX/lib to OSX conf

93ade51

Support BLAS

a898711

jakirkham reviewed Nov 1, 2016

View reviewed changes

Add license_family: BSD and remove matplotlib from build req

0e427a9

jakirkham reviewed Nov 2, 2016

View reviewed changes

basnijholt added 7 commits November 2, 2016 18:24

add yum_requirements.txt

5d07dc2

drop libgcc

1fa284c

export LIBRARY_PATH in build.sh

c1d6b89

add libgfortran in build requirements

1ba470d

Only Python 2.7

f32eb41

add export LD_LIBRARY_PATH to build.sh

d66bf7a

build req: gcc only for osx and libgfortran only linux

a1fa071

jakirkham reviewed Nov 2, 2016

View reviewed changes

combine skip: true # [win or py3k]

82ea10c

jakirkham reviewed Nov 2, 2016

View reviewed changes

change numpy -> numpy x.x

e2bb0c2

fix style error [skip appveyor]

237610b

jakirkham closed this Nov 2, 2016

jakirkham reopened this Nov 2, 2016

jakirkham merged commit 968efa5 into conda-forge:master Nov 3, 2016

Added recipe for kwant #1446

Added recipe for kwant #1446

Conversation

basnijholt commented Aug 31, 2016 • edited Loading

conda-forge-linter commented Aug 31, 2016

basnijholt commented Aug 31, 2016

basnijholt commented Aug 31, 2016 • edited Loading

Choose a reason for hiding this comment

conda-forge-linter commented Aug 31, 2016

Choose a reason for hiding this comment

jakirkham commented Aug 31, 2016

basnijholt commented Aug 31, 2016 • edited Loading

basnijholt commented Aug 31, 2016 • edited Loading

basnijholt commented Aug 31, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basnijholt commented Nov 1, 2016 • edited Loading

Choose a reason for hiding this comment

basnijholt Nov 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basnijholt Nov 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham Nov 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conda-forge-linter commented Nov 2, 2016

Choose a reason for hiding this comment

basnijholt Nov 2, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jakirkham commented Nov 2, 2016

conda-forge-linter commented Nov 2, 2016

jakirkham commented Nov 2, 2016

basnijholt commented Nov 2, 2016

jakirkham commented Nov 2, 2016

jakirkham commented Nov 2, 2016

basnijholt commented Nov 3, 2016

jakirkham commented Nov 3, 2016

basnijholt commented Aug 31, 2016 •

edited

Loading

basnijholt commented Aug 31, 2016 •

edited

Loading

basnijholt commented Aug 31, 2016 •

edited

Loading

basnijholt commented Aug 31, 2016 •

edited

Loading

basnijholt commented Aug 31, 2016 •

edited

Loading

basnijholt commented Nov 1, 2016 •

edited

Loading

basnijholt Nov 2, 2016 •

edited

Loading

basnijholt Nov 2, 2016 •

edited

Loading

jakirkham Nov 2, 2016 •

edited

Loading

basnijholt Nov 2, 2016 •

edited

Loading