Added recipe for scotch #1427
Added recipe for scotch #1427
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/scotch:
|
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/scotch:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Could you please restore the |
| sed -i "s@CLIBFLAGS\t=@CLIBFLAGS\t= -fPIC@g" Makefile.inc | ||
| sed -i 's#-l$(SCOTCHLIB)errexit#-l$(SCOTCHLIB)errexit -lm#g' esmumps/Makefile | ||
| fi | ||
| make esmumps | tee make.log 2>&1 |
| sed -i '' 's/-O3/-O3 -fPIC/g' Makefile.inc | ||
| else | ||
| cp Make.inc/Makefile.inc.x86-64_pc_linux2 Makefile.inc | ||
| sed -i "s@CFLAGS\t\t=@CFLAGS\t= -I${PREFIX}/include@" Makefile.inc |
There was a problem hiding this comment.
Might need to do this for the library search path too.
There was a problem hiding this comment.
I don't know why or how?
There was a problem hiding this comment.
Why would be to pick up zlib.
How would be to add -L${PREFIX}/lib. Though I really am hoping they have a configure file we overlooked.
There was a problem hiding this comment.
So I looked at the source briefly. They don't have a configure. 😖
My recommendation would be to copy these files into the recipe and modify them as you see fit. We did this with SuiteSparse and had much success. Keeping this sed stuff is more likely to cause you hurt later on.
| source: | ||
| fn: scotch_{{ version }}.tar.gz | ||
| md5: {{ md5 }} | ||
| url: http://gforge.inria.fr/frs/download.php/file/34618/scotch_6.0.4.tar.gz |
There was a problem hiding this comment.
scotch_6.0.4.tar.gz -> scotch_{{ version }}.tar.gz. That should make it easier to update. 😉
| - test -f "${PREFIX}/lib/libscotcherr.a" | ||
| - test -f "${PREFIX}/lib/libscotcherrexit.a" | ||
| - test -f "${PREFIX}/lib/libscotchmetis.a" | ||
| - test -f "${PREFIX}/lib/libesmumps.a" |
There was a problem hiding this comment.
@jakirkham I can't find a better way to test these files? What do you think?
There was a problem hiding this comment.
Can we check for some dylibs/sos? Also some tests for installed headers would be helpful.
There was a problem hiding this comment.
There are no dylibs/sos as far as I can see. I did include the header file tests now.
There was a problem hiding this comment.
Yeah, I'm not seeing them either now that I'm looking. Is there an option to build dynamic libraries?
| CAT = cat | ||
| CCS = gcc | ||
| CCP = mpicc | ||
| CCD = gcc |
There was a problem hiding this comment.
Changed to clang
There was a problem hiding this comment.
Should I do it in the Linux Makefile.inc too?
| version: {{ version }} | ||
|
|
||
| source: | ||
| fn: scotch_6.0.4.tar.gz |
There was a problem hiding this comment.
Please change to {{ name }}-{{ version }}.tar.gz.
There was a problem hiding this comment.
Now jinja templated
| source: | ||
| fn: scotch_6.0.4.tar.gz | ||
| md5: {{ md5 }} | ||
| url: http://gforge.inria.fr/frs/download.php/file/34618/scotch_6.0.4.tar.gz |
There was a problem hiding this comment.
Please template the version with jinja here.
There was a problem hiding this comment.
I changed it, but because the number in the url changes for every file I initially didn't.
| version: {{ version }} | ||
|
|
||
| source: | ||
| fn: scotch_6.0.4.tar.gz |
There was a problem hiding this comment.
Now jinja templated
| CAT = cat | ||
| CCS = gcc | ||
| CCP = mpicc | ||
| CCD = gcc |
There was a problem hiding this comment.
Changed to clang
|
@jakirkham I've changed what you suggested, two things left:
I don't see that there are any dylibs or sos files generated
I have changed it for the MacOS makefile, but should I do it for Linux too? |
| source: | ||
| fn: {{ name }}-{{ version }}.tar.gz | ||
| md5: {{ md5 }} | ||
| url: http://gforge.inria.fr/frs/download.php/file/34618/{{ name }}-{{ version }}.tar.gz |
There was a problem hiding this comment.
Could try the link below. The number on it doesn't seem to change with each release. So it works better with templating.
https://gforge.inria.fr/frs/download.php/latestfile/298/{{ name }}_{{ version }}.tar.gz
|
Seems to be picking up the system |
| - zlib 1.2.* # [unix] | ||
|
|
||
| test: | ||
| commands: |
There was a problem hiding this comment.
There seems to be a bunch of executables that are installed. Can we please run --help or --version or similar to check that they do run without crashing?
There was a problem hiding this comment.
I have added a few.
|
I have changed everything @jakirkham suggested, except that I don't know how to generate dynamic libraries, the |
|
@jakirkham I've checked there is a Makefile.inc for Linux, not for OSX. However, it's not compiling correctly (d87384b), so I reverted the change. |
|
I have spend a lot of time to get the dynamic lib compilation to work, but it's not working. Also by looking for info about the |
|
No worries. I think we are now at a healthy place to merge. While there is still room for growth, I'm more than happy to see that continue at the feedstock. Thanks very much for your hard work, @basnijholt . |
No description provided.