Add recipe for tinyarray #1444

basnijholt · 2016-08-31T10:49:22Z

No description provided.

conda-forge-linter · 2016-08-31T10:49:24Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinyarray) and found it was in an excellent condition.

jakirkham · 2016-09-03T03:31:17Z

recipes/tinyarray/meta.yaml

+    - toolchain
+  run:
+    - python
+    - nose


We need nose at build and run?

You are right, it only needs it for building.

patricksnape · 2016-09-03T11:25:11Z

It looks like this should build on Windows, the project is just using some Python functionality that doesn't exist on Windows in the setup.py (namely os.path.samefile). It looks like this is a custom method for getting the version from git - have you thought about using versioneer instead?

patricksnape · 2016-09-03T15:06:28Z

Add the <algorithm> header to get std::max

basnijholt · 2016-09-03T15:10:49Z

I'm not really at home with C, so could you maybe help me by giving me the line I can copy paste into one of these files?

Edit: that was actually really easy...

basnijholt · 2016-09-03T15:23:13Z

Can someone help me on how I can run this Python file as test in meta.yaml?

The file is in MANIFEST.in, but I don't know where it is coppied.

For running that test file (test_tinyarray.py), nose is needed, does that make it a runtime dependency?

patricksnape · 2016-09-03T15:28:52Z

recipes/tinyarray/meta.yaml

+  build:
+    - python
+    - setuptools
+    - nose


This isn't needed for building.

conda-forge-linter · 2016-09-03T15:34:38Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tinyarray) and found some lint.

Here's what I've got...

For recipes/tinyarray:

Failed to even lint the recipe (might be a conda-smithy bug) 😢

patricksnape · 2016-09-03T15:37:09Z

recipes/tinyarray/meta.yaml

+  source_files:
+    - test_tinyarray.py
+  commands:
+    - $PYTHON test_tinyarray.py   # [unix]


OK apparently Jinja doesn't like that, so just merge those two lines into a single one python test_tinyarray.py - sorry!

conda-forge-linter · 2016-09-03T15:40:07Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tinyarray) and found it was in an excellent condition.

basnijholt · 2016-09-03T15:43:51Z

Why does this Error: in section 'test': unknown key 'source_files' happen?

Outdated conda-build?

msarahan · 2016-09-03T15:50:13Z

source_files was added in 2.0. It will not work with earlier conda-build
versions.

On Sat, Sep 3, 2016 at 10:43 AM Bas Nijholt [email protected]
wrote:

Why does this Error: in section 'test': unknown key 'source_files' happen?

Outdated conda-build?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1444 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACV-RQV1reXBCS5cYHMzwq2uuqxiNdoks5qmZW3gaJpZM4JxekI
.

basnijholt · 2016-09-03T15:51:33Z

How can I use 2.0?

patricksnape · 2016-09-03T15:52:22Z

You can't until we fix a conda-build-setup bug.

basnijholt · 2016-09-03T15:54:47Z

Let me comment out the tests untill then.

patricksnape · 2016-09-03T16:02:24Z

The setup.py requires nose for setup but I don't think it should.

patricksnape · 2016-09-03T16:04:15Z

Well, that's not true, if you want to use setup.py test - re-add nose to the build requirements if you don't want to change the setup.py - apologies!

Update `staged-recipes`

basnijholt · 2016-09-03T16:41:40Z

I opened a pull request to fix it (shamelessly copied this).

patricksnape · 2016-09-03T21:14:36Z

recipes/tinyarray/meta.yaml

+
+source:
+  fn: v{{ version }}.tar.gz
+  url: https://gitlab.kwant-project.org/basnijholt/tinyarray/repository/archive.tar.gz?ref=v{{ version }}


So is this a tag or a branch? Is this the main repository?

This is not the main repository, I've opened a pull request.

rerender

dopplershift

This seems ready to go now.

Initial commit for tinyarray

5eab956

basnijholt added 3 commits August 31, 2016 12:55

gcc -> toolchain

91790a6

Skip Windows

10dab31

Add newline

9554b9c

basnijholt mentioned this pull request Aug 31, 2016

Added recipe for kwant #1446

Merged

4 tasks

basnijholt added 5 commits August 31, 2016 14:41

Change BSD to BSD 2-Clause

c818224

Update source from git to archive.tar.gz

a4e551c

Correct sha256

3a52ab9

kwant -> tinyarray

4989d3a

Correct sha256 to .tar.gz file

f6ac41a

jakirkham reviewed Sep 3, 2016
View reviewed changes

Remove nose as runtime dependency

38c6ba6

basnijholt added 4 commits September 3, 2016 16:38

Trying out versioneer

2a51219

Update sha256

02911c5

Change sha256 to latest commit

b6223b1

Add test_tinyarray.py

ddc0459

basnijholt added 3 commits September 3, 2016 17:11

Current version of conda-build doesn't recognize source_files

7ed924b

New sha256 with <algorithm> header

93e1787

Remove test

e317bbd

patricksnape reviewed Sep 3, 2016
View reviewed changes

recipes/tinyarray/meta.yaml

build:

- python

- setuptools

- nose

Copy link

Contributor

patricksnape Sep 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't needed for building.

Add tests

8dcd7d4

patricksnape reviewed Sep 3, 2016
View reviewed changes

python test_tinyarray.py

ba8a0ee

Comment out test_tinyarray.py

c03cfee

basnijholt added 2 commits September 3, 2016 18:28

Merge pull request #2 from conda-forge/master

126ce25

Update `staged-recipes`

Add nose to build requirements again

c9fe529

patricksnape reviewed Sep 3, 2016
View reviewed changes

msarahan added the conda-build-2 label Sep 4, 2016

basnijholt added 8 commits September 5, 2016 16:03

conda_test tag

8854e1b

Define version

36398ae

Update to official v1.2.0a1

a2d19c1

Change sh256 to v1.2.0a1

c4e2cb2

Uncommenting tests that require conda-build 2.0.0

87d620f

Add numpy as test requirement

ae46110

Merge pull request #4 from conda-forge/master

8b405d0

rerender

update description

790257c

basnijholt mentioned this pull request Oct 10, 2016

Add recipe for discretizer #1747

Merged

5 tasks

basnijholt added 2 commits October 26, 2016 09:09

Comment out conda build 2 part

a6582a2

change doc_url and comment out nose for building for conda build 1

7d8e2e5

dopplershift approved these changes Oct 26, 2016

View reviewed changes

ocefpaf merged commit 8562e87 into conda-forge:master Oct 27, 2016

basnijholt deleted the tinyarray branch October 27, 2016 10:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recipe for tinyarray #1444

Add recipe for tinyarray #1444

basnijholt commented Aug 31, 2016

conda-forge-linter commented Aug 31, 2016

jakirkham Sep 3, 2016

basnijholt Sep 3, 2016

patricksnape commented Sep 3, 2016

patricksnape commented Sep 3, 2016

basnijholt commented Sep 3, 2016 •

edited

Loading

basnijholt commented Sep 3, 2016 •

edited

Loading

patricksnape Sep 3, 2016

conda-forge-linter commented Sep 3, 2016

patricksnape Sep 3, 2016

conda-forge-linter commented Sep 3, 2016

basnijholt commented Sep 3, 2016

msarahan commented Sep 3, 2016

basnijholt commented Sep 3, 2016

patricksnape commented Sep 3, 2016 •

edited

Loading

basnijholt commented Sep 3, 2016

patricksnape commented Sep 3, 2016

patricksnape commented Sep 3, 2016

basnijholt commented Sep 3, 2016 •

edited

Loading

patricksnape Sep 3, 2016

basnijholt Sep 3, 2016

dopplershift left a comment

Add recipe for tinyarray #1444

Add recipe for tinyarray #1444

Conversation

basnijholt commented Aug 31, 2016

conda-forge-linter commented Aug 31, 2016

jakirkham Sep 3, 2016

Choose a reason for hiding this comment

basnijholt Sep 3, 2016

Choose a reason for hiding this comment

patricksnape commented Sep 3, 2016

patricksnape commented Sep 3, 2016

basnijholt commented Sep 3, 2016 • edited Loading

basnijholt commented Sep 3, 2016 • edited Loading

patricksnape Sep 3, 2016

Choose a reason for hiding this comment

conda-forge-linter commented Sep 3, 2016

patricksnape Sep 3, 2016

Choose a reason for hiding this comment

conda-forge-linter commented Sep 3, 2016

basnijholt commented Sep 3, 2016

msarahan commented Sep 3, 2016

basnijholt commented Sep 3, 2016

patricksnape commented Sep 3, 2016 • edited Loading

basnijholt commented Sep 3, 2016

patricksnape commented Sep 3, 2016

patricksnape commented Sep 3, 2016

basnijholt commented Sep 3, 2016 • edited Loading

patricksnape Sep 3, 2016

Choose a reason for hiding this comment

basnijholt Sep 3, 2016

Choose a reason for hiding this comment

dopplershift left a comment

Choose a reason for hiding this comment

basnijholt commented Sep 3, 2016 •

edited

Loading

basnijholt commented Sep 3, 2016 •

edited

Loading

patricksnape commented Sep 3, 2016 •

edited

Loading

basnijholt commented Sep 3, 2016 •

edited

Loading