Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Upload script fails with conda_build >= 2.0.0 #28

Closed
jjhelmus opened this issue Aug 31, 2016 · 4 comments
Closed

Upload script fails with conda_build >= 2.0.0 #28

jjhelmus opened this issue Aug 31, 2016 · 4 comments

Comments

@jjhelmus
Copy link
Contributor

Copied from conda-forge/conda-smithy#282

conda build version 2.0.0 changed the call signature of the bldpkg_path() function so that it now takes a second config argument. This breaks the upload_or_check_non_existence.py script in conda-smithy, see conda-forge/doctr-feedstock#5.

A temporary fix which pins conda-build to 1.x was made in #27 but should be reverted once the upload script is updated to account for this new call signature.

@jjhelmus
Copy link
Contributor Author

The following change around line 25 to the upload_or_check_non_existence.py script seems to fix the issue and would allow for compatibility between conda build 1.x and 2.x:

try:
     fname = bldpkg_path(meta)
except TypeError:
     # conda-build >= 2.0.0 takes a config argument
     from conda_build.config import Config
     config = Config()
     fname = bldpkg_path(meta, config)

I would appreciate hearing what @msarahan or @pelson thinks of this change.

@msarahan
Copy link
Member

That change would be fine.

@pelson
Copy link
Member

pelson commented Sep 1, 2016

Yep, I'd merge this.

@pelson
Copy link
Member

pelson commented Oct 1, 2016

This is now fixed, and conda-smithy is now directing feedstocks at the script in this repo.

@pelson pelson closed this as completed Oct 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants