Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.12 #110

Merged
merged 147 commits into from
Aug 8, 2019
Merged

v5.12 #110

merged 147 commits into from
Aug 8, 2019

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jul 25, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #75
Fixes #101

@isuruf
Copy link
Member Author

isuruf commented Jul 26, 2019

Waiting for AnacondaRecipes/aggregate#164 to merge conda-forge/clangdev-feedstock#55 and get libclang.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 26, 2019

Waiting for AnacondaRecipes/aggregate#164 to merge conda-forge/clangdev-feedstock#55 and get libclang.

I know that @msarahan is working on AnacondaRecipes/aggregate#164 and that should be rebuild soon. Let's keep an eye for it.

@ccordoba12
Copy link
Contributor

@isuruf, please change the build directory on Windows from D:\ to C:\ to get more space for the build. That's always changed when re-rendering the feedstock (like in PR #108):

https://github.com/conda-forge/qt-feedstock/pull/108/files#diff-3bdc3996454bb34a0d6efc35493f5cb8L15

@isuruf
Copy link
Member Author

isuruf commented Aug 7, 2019

I've changed it but this PR would time out in azure anyway.

@ccordoba12
Copy link
Contributor

Sure, it's just to see if other errors appear during the build before it times out.

@isuruf
Copy link
Member Author

isuruf commented Aug 8, 2019

Thanks to @msarahan for providing me with a 8 core windows machine to debug and for the sagemath project for the 48 core linux machine. I've built the linux and windows packages and uploaded them.

(Windows packages were built with VS 2019 with VS 2017 toolset activated. Had to hack the scripts from vs2017_win-64 manually, but it should work.)

@isuruf isuruf merged commit ef2a0d0 into conda-forge:master Aug 8, 2019
@isuruf isuruf deleted the master-5.12 branch August 8, 2019 00:47
@ocefpaf
Copy link
Member

ocefpaf commented Aug 8, 2019

@isuruf this is awesome! I'll put a migrator for the new qt later today.

@dhirschfeld
Copy link
Member

Wow - this is awesome! Thanks all for the huge effort getting this over the line! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qt5.12
7 participants