Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyQt 5.12.3 #61

Merged
merged 30 commits into from
Oct 7, 2019
Merged

Support PyQt 5.12.3 #61

merged 30 commits into from
Oct 7, 2019

Conversation

leofang
Copy link
Member

@leofang leofang commented Aug 9, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Resolves #58.
Closes #59
Closes #60

I don't have a Windows machine, so I can't test the Win build. Tested locally on a Linux machine (I have neither root privilege on it nor control over its Conda root environment) against the recent Qt 5.12 package (conda-forge/qt-feedstock#110).

Note that a private copy of the sip module is necessary for PyQt 5.11+ (conda-forge/sip-feedstock#16), unless changes are made on the sip-feedstock side.

ps. I didn't realize until now that there're parallel efforts (#59, #60) 😦 But, this PR demonstrates how to resolve the PyQt5.sip not found issue (in a brute force way...) Hope this helps.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@leofang
Copy link
Member Author

leofang commented Aug 9, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@leofang
Copy link
Member Author

leofang commented Aug 9, 2019

ps. Please feel free to take over or close this PR as you see fit. I'm happy as long as a newer package can be built.

@ccordoba12
Copy link
Contributor

Thanks for the tip about PyQt5.sip. I'll take into account to finish #59.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Sep 19, 2019

@conda-forge-admin, please rerender

@leofang
Copy link
Member Author

leofang commented Sep 19, 2019

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

@leofang
Copy link
Member Author

leofang commented Sep 20, 2019

With --debug turned on the error becomes LINK : fatal error LNK1104: cannot open file 'Qt5Core_condad.lib' instead of cannot open shell32.lib.

@leofang
Copy link
Member Author

leofang commented Sep 20, 2019

I cleaned up debug prints and suppressed Windows build in 88cba5b. For Linux and Mac OS X this PR is ready to go.

@isuruf
Copy link
Member

isuruf commented Sep 21, 2019

Issue is that qt=5.12 was built on @msarahan's computer and it has a newer SDK than what azure has. Qt somehow saves the paths and this issue pops up.

@leofang
Copy link
Member Author

leofang commented Sep 21, 2019

@isuruf Oh OK do you want me to turn on the Windows build, or you can take over from here?

@msarahan
Copy link
Member

Do we need a build against an older SDK? (the one on Azure, presumably?)

@isuruf
Copy link
Member

isuruf commented Sep 23, 2019

@msarahan, yes. we need to build qt against >=10.0.16299.0,<=10.0.17763.0

@msarahan
Copy link
Member

OK, I'll rebuild it when I get home tonight.

@isuruf
Copy link
Member

isuruf commented Sep 23, 2019

@msarahan, @mingwandroid said he might do it today as well.

@msarahan
Copy link
Member

Great, I'll coordinate with him on it.

@leofang
Copy link
Member Author

leofang commented Sep 24, 2019

@isuruf I don't think you can restore py27...It's a bug on PyQt, not on Qt, so a newer Qt (I see 5.12.5 was just built!) isn't helping.

@leofang
Copy link
Member Author

leofang commented Sep 24, 2019

Issue is that qt=5.12 was built on @msarahan's computer and it has a newer SDK than what azure has. Qt somehow saves the paths and this issue pops up.

I think you're right, @isuruf! Windows build is still running on Azure without failing 🎉

@leofang
Copy link
Member Author

leofang commented Sep 24, 2019

Try nmake throughout in Win builds. I found that jom is often unable to find the files to be copied over.

@jschueller
Copy link
Contributor

cool, it builds!

@isuruf isuruf merged commit 0782e60 into conda-forge:master Oct 7, 2019
@leofang leofang deleted the pyqt5.12.3 branch October 7, 2019 15:29
@leofang leofang restored the pyqt5.12.3 branch October 7, 2019 15:29
@leofang
Copy link
Member Author

leofang commented Oct 7, 2019

Thank you very much @isuruf for finishing the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Qt / PyQt5 for 5.10+
8 participants