-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PyQt 5.12.3 #61
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
ps. Please feel free to take over or close this PR as you see fit. I'm happy as long as a newer package can be built. |
Thanks for the tip about PyQt5.sip. I'll take into account to finish #59. |
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to re-render for you, but it looks like there was nothing to do. |
With |
…ag and patch temporarily turned off -- debug in progress
I cleaned up debug prints and suppressed Windows build in 88cba5b. For Linux and Mac OS X this PR is ready to go. |
Issue is that qt=5.12 was built on @msarahan's computer and it has a newer SDK than what azure has. Qt somehow saves the paths and this issue pops up. |
@isuruf Oh OK do you want me to turn on the Windows build, or you can take over from here? |
Do we need a build against an older SDK? (the one on Azure, presumably?) |
@msarahan, yes. we need to build qt against |
OK, I'll rebuild it when I get home tonight. |
@msarahan, @mingwandroid said he might do it today as well. |
Great, I'll coordinate with him on it. |
@isuruf I don't think you can restore py27...It's a bug on PyQt, not on Qt, so a newer Qt (I see 5.12.5 was just built!) isn't helping. |
Try |
cool, it builds! |
Thank you very much @isuruf for finishing the PR! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Resolves #58.
Closes #59
Closes #60
I don't have a Windows machine, so I can't test the Win build. Tested locally on a Linux machine (I have neither root privilege on it nor control over its Conda root environment) against the recent Qt 5.12 package (conda-forge/qt-feedstock#110).
Note that a private copy of the
sip
module is necessary for PyQt 5.11+ (conda-forge/sip-feedstock#16), unless changes are made on the sip-feedstock side.ps. I didn't realize until now that there're parallel efforts (#59, #60) 😦 But, this PR demonstrates how to resolve the
PyQt5.sip
not found issue (in a brute force way...) Hope this helps.