Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better solution for the sip recipe #16

Closed
leofang opened this issue Aug 9, 2019 · 3 comments
Closed

Need a better solution for the sip recipe #16

leofang opened this issue Aug 9, 2019 · 3 comments

Comments

@leofang
Copy link
Member

leofang commented Aug 9, 2019

While #15 supports the most recent version 4.19.18, note that since PyQt 5.11 a private copy of sip needs to be built: https://www.riverbankcomputing.com/static/Docs/PyQt5/installation.html#downloading-sip
that is, for the purpose of supporting PyQt5, the flag --sip-module PyQt5.sip needs to be used when building sip, otherwise there would be a ModuleNotFoundError for PyQt5.sip. But, adding that flag also means import sip no longer works.

Currently, #15 does not have that flag, so a PyQt 5.12 recipe (corresponding to recently merged PR conda-forge/qt-feedstock#110) can not depend on conda-forge's sip anymore. Any suggestion?

This is for resolving conda-forge/pyqt-feedstock#58.

@leofang
Copy link
Member Author

leofang commented Aug 9, 2019

@leofang
Copy link
Member Author

leofang commented Aug 20, 2019

No up to date package should be using a top-level sip module.

See source. I guess this eliminates the majority need of having a standalone sip package except for backward compatibility...

@leofang
Copy link
Member Author

leofang commented Oct 10, 2019

Closing this issue. Note that starting conda-forge/pyqt-feedstock#61 PyQt5 no longer depends on the sip package; a private copy of sip is built and shipped with it.

@leofang leofang closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant