Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual migration for PyPy windows #298

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Manual migration for PyPy windows #298

merged 3 commits into from
Aug 9, 2021

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Aug 6, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The migrations dependency resolver ignored the selector on pyqt, and is waiting for pyqt (which will not work on PyPy), so try this manually.

I did not update the build number since this is a migration.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Contributor Author

mattip commented Aug 6, 2021

Hit a build error in _c_internal_utils.c in return PyErr_SetFromWindowsErr(hr);

src/_c_internal_utils.c(71): error C2440: 'return': cannot convert from 'void' to 'PyObject *'

PyPy doesnt' do this right. Patch needed.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [14]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Contributor Author

mattip commented Aug 6, 2021

It seems some other package is not available yet? I am not sure which one.

@mattip
Copy link
Contributor Author

mattip commented Aug 8, 2021

Close/reopen to restart CI

@mattip mattip closed this Aug 8, 2021
@mattip mattip reopened this Aug 8, 2021
@mattip
Copy link
Contributor Author

mattip commented Aug 8, 2021

CI is passing.

@ocefpaf ocefpaf merged commit 818dedd into conda-forge:master Aug 9, 2021
@mattip
Copy link
Contributor Author

mattip commented Aug 9, 2021

Thanks!

@dopplershift dopplershift mentioned this pull request Aug 13, 2021
4 tasks
@mattip
Copy link
Contributor Author

mattip commented Aug 17, 2021

This is still marked on the PyPy windows migration as "waiting for parents" @isuruf is that blocking anything, and if so is there a way around it?

@isuruf
Copy link
Member

isuruf commented Aug 17, 2021

cc @conda-forge/bot

@mattip
Copy link
Contributor Author

mattip commented Aug 20, 2021

I still see this as "waiting for parents" on the PyPy windows migration, even though this PR was merged. Is there a way around that?

@mattip
Copy link
Contributor Author

mattip commented Aug 4, 2022

Hmm. The migration bot still does not recognize matplotlib as updated.

@dopplershift
Copy link
Member

@mattip Just to be clear, this is last year's issue. Probably meant #322.

@mattip
Copy link
Contributor Author

mattip commented Aug 4, 2022

Thanks for the correction, yes I meant #322. The PRs were similarly named, sorry for the confusion. In any case any ideas how to convince the migration bot that this package is available for pypy3.8/3.9?

@jakirkham
Copy link
Member

xref: #322 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants