Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpause win-pypy migration #1714

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Jul 21, 2021

Follows #1668 & #1670, now that numpy has been built, see here.

CC @isuruf @beckermr @mattip

@h-vetinari h-vetinari requested a review from a team as a code owner July 21, 2021 22:17
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf merged commit 109afa6 into conda-forge:master Jul 21, 2021
@h-vetinari h-vetinari deleted the unpause-win-pypy branch July 22, 2021 09:00
@mattip
Copy link
Contributor

mattip commented Aug 6, 2021

Do you understand why the migration status shows matplotlib as a child of pyqt (in the In-PR section)? The recipe only requires pyqt for CPython

@h-vetinari
Copy link
Member Author

I think that's a simple case of the migrator not taking into account selectors. In such cases (barring changes to the migrator, cf. regro/cf-scripts#1331 / regro/cf-scripts#1332), you can simply do a manual migration like conda-forge/numpy-feedstock#238

@mattip
Copy link
Contributor

mattip commented Aug 6, 2021

xref conda-forge/matplotlib-feedstock#298. Once (if?) that goes in, will the migrator then notice and continue from there?

@h-vetinari
Copy link
Member Author

Once (if?) that goes in, will the migrator then notice and continue from there?

No, the migrator only knows its own PRs. But one could then close the pyqt one, and would then continue, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants