Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test requirements only if we are building that node #1332

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Jan 12, 2021

Fixes #1331

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #1332 (6930f03) into master (f0214de) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   57.65%   57.62%   -0.03%     
==========================================
  Files          66       66              
  Lines        6570     6573       +3     
==========================================
  Hits         3788     3788              
- Misses       2782     2785       +3     
Impacted Files Coverage Δ
conda_forge_tick/migrators/migration_yaml.py 55.79% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0214de...6930f03. Read the comment docs.

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we also keeping the build/host here too? I think we can get rid of those as well for nodes we do not build, right?

@beckermr beckermr merged commit 2d1c0b6 into regro:master Jan 12, 2021
@beckermr
Copy link
Contributor

We can remove those in another PR if we want.

@beckermr
Copy link
Contributor

Thanks @isuruf for the clever fix!

@isuruf
Copy link
Member Author

isuruf commented Jan 12, 2021

Why are we also keeping the build/host here too? I think we can get rid of those as well for nodes we do not build, right?

Depends on if the code here handles run_exports correctly or not.

@h-vetinari
Copy link
Contributor

Very cool, thanks!

@beckermr
Copy link
Contributor

I think we handle run exports correctly now when building the graph nodes. Or at least we are doing it better than before.

I'll make a PR to remove them and we can see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration metadata for dependencies seems off
3 participants