Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manually start PyPy migration #322

Merged
merged 2 commits into from
Jul 28, 2022
Merged

manually start PyPy migration #322

merged 2 commits into from
Jul 28, 2022

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Jul 28, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

The dependency resolver bot did not start the pypy3.8/3.9 migration because pyqt is a parent in the graph. But I think pyqt is an optional dependency, not a hard one. The PR works around the problem by manually adding the migration file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mattip
Copy link
Contributor Author

mattip commented Jul 28, 2022

For some reason CI did not start.

@conda-forge-admin please restart ci

@dopplershift dopplershift merged commit da0e517 into conda-forge:main Jul 28, 2022
@mattip
Copy link
Contributor Author

mattip commented Jul 28, 2022

Thanks!

@jakirkham
Copy link
Member

Thanks Matti and Ryan! 🙏

@mattip
Copy link
Contributor Author

mattip commented Jul 31, 2022

This package is now available, but the migration bot doesn't seem to have picked it up. matplotlib is still at the top of the "awaiting parents" group on the pypy3.8 migration. Is there a way to tell the bot that this migration is finished?

@jakirkham
Copy link
Member

cc @conda-forge/bot

@jakirkham
Copy link
Member

Surfaced the discussion here on Gitter.

@mattip
Copy link
Contributor Author

mattip commented Aug 23, 2022

Still no movement, migration of the package seems in limbo.

@jakirkham
Copy link
Member

Would just raise it in the meeting this week

@chrisburr
Copy link
Member

I think it's because pyqt isn't migrated so it's not even considering matplotlib yet. Either that PR should be fixed or we can probably edit the bot metadata directly.

I think this would involve adding a section like:

to:

I'll try to take a look this morning.

@chrisburr
Copy link
Member

Actually I found the proper fix that matches how this has been done for pypy37: conda-forge/conda-forge-pinning-feedstock#3326

@mattip
Copy link
Contributor Author

mattip commented Aug 25, 2022

Great, the migration seems unstuck now.

@jakirkham
Copy link
Member

Thanks Chris! 🙏

Maybe we should document this for future reference. Matti, would you be willing to add this to the docs?

@mattip
Copy link
Contributor Author

mattip commented Aug 25, 2022

the docs

Sure, where in the docs would be appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants