-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gap v4.12.2 #68
gap v4.12.2 #68
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@isuruf @saraedum Could you please try to merge this upgrade here? Sage is now using v4.12 since sagemath/sage#35093, and due to api changes it no longer builds with v4.11. Thanks! |
It errors out on patching GAP source, specifically:
This is a script used by the standard GAP way of building/installing packages. Sage is not using it, by the way. |
please merge my fix at regro-cf-autotick-bot#1 to fix the error. |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
oops, the other patch failed too, sorry. Fix forthcoming |
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
@conda-forge-admin, rerender |
…nda-forge-pinning 2023.03.26.16.10.11
…ould not know where to find it anyway
This comment was marked as resolved.
This comment was marked as resolved.
I don't understand what they were good for but maybe they are not needed anymore
why is this now in core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think it's a bad idea to install a crippled GAP w/o its built-in help.
I now see that the documentation is patched out because it is "too heavy". What does that even mean? What is the criterion here? Speaking cynically, that sound as if when I document my code too thoroughly, the result will be deleted by Conda because it is too long? I surely hope that's not the idea... |
Anyway, other than the documentation question, I think this PR is looking really good now. Thank you very much to all who worked on this! |
SageMath does install GAP's documentation, by the way. I also don't get
Conda's rationale for removing it.
…On Fri, 7 Apr 2023, 11:25 Max Horn, ***@***.***> wrote:
Anyway, other than the documentation question, I think this PR is looking
really good now. Thank you very much to all who worked on this!
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJXYHAX4M77JDV6JDBHRXTW77TP5ANCNFSM6AAAAAAU67KFR4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for the feedback @fingolfin. Let's get this merged as is, so we don't block the latest sagelib any further. And then we can tweak things further. |
A big thanks to everyone involved, the updated version works well for me with sage! |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4200475742, please use this URL for debugging.