Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gap v4.12.2 #68

Merged
merged 45 commits into from
Apr 8, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
bliss 0.73-1 Anaconda-Server Badge
gap 4.12.2 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4200475742, please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@tobiasdiez
Copy link

@isuruf @saraedum Could you please try to merge this upgrade here? Sage is now using v4.12 since sagemath/sage#35093, and due to api changes it no longer builds with v4.11. Thanks!

@dimpase
Copy link
Contributor

dimpase commented Mar 26, 2023

It errors out on patching GAP source, specifically:

checking file bin/BuildPackages.sh
Hunk #1 FAILED at 179.
1 out of 1 hunk FAILED

This is a script used by the standard GAP way of building/installing packages. Sage is not using it, by the way.

@dimpase
Copy link
Contributor

dimpase commented Mar 26, 2023

please merge my fix at regro-cf-autotick-bot#1 to fix the error.

@dimpase
Copy link
Contributor

dimpase commented Mar 26, 2023

@saraedum @isuruf

@saraedum saraedum added the automerge Merge the PR when CI passes label Mar 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@dimpase
Copy link
Contributor

dimpase commented Mar 26, 2023

oops, the other patch failed too, sorry. Fix forthcoming

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Mar 26, 2023
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@isuruf
Copy link
Member

isuruf commented Mar 27, 2023

@conda-forge-admin, rerender

@isuruf isuruf added the automerge Merge the PR when CI passes label Mar 27, 2023
@isuruf isuruf added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Mar 27, 2023
@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Mar 27, 2023
@saraedum

This comment was marked as resolved.

I don't understand what they were good for but maybe they are not needed
anymore
why is this now in core?
Copy link
Contributor

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think it's a bad idea to install a crippled GAP w/o its built-in help.

recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Outdated Show resolved Hide resolved
recipe/build.sh Show resolved Hide resolved
recipe/install-core.sh Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
recipe/build.sh Show resolved Hide resolved
recipe/install-core.sh Outdated Show resolved Hide resolved
recipe/install-core.sh Show resolved Hide resolved
recipe/install-core.sh Show resolved Hide resolved
@fingolfin
Copy link
Contributor

fingolfin commented Apr 7, 2023

I now see that the documentation is patched out because it is "too heavy". What does that even mean? What is the criterion here? Speaking cynically, that sound as if when I document my code too thoroughly, the result will be deleted by Conda because it is too long? I surely hope that's not the idea...

@fingolfin
Copy link
Contributor

Anyway, other than the documentation question, I think this PR is looking really good now. Thank you very much to all who worked on this!

@dimpase
Copy link
Contributor

dimpase commented Apr 7, 2023 via email

README.md Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Show resolved Hide resolved
@saraedum saraedum added the automerge Merge the PR when CI passes label Apr 8, 2023
@saraedum
Copy link
Member

saraedum commented Apr 8, 2023

Thanks for the feedback @fingolfin. Let's get this merged as is, so we don't block the latest sagelib any further. And then we can tweak things further.

@github-actions github-actions bot merged commit 653a189 into conda-forge:main Apr 8, 2023
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 4.12.2_hb63a01 branch April 8, 2023 19:45
@tobiasdiez
Copy link

A big thanks to everyone involved, the updated version works well for me with sage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants