Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum version of conda gap package #35351

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Mar 26, 2023

📚 Description

Since #35093, sage no longer builds with gap 4.11. With this PR the new minimum version is correctly specified for the conda installation. This currently doesn't work as there is no suitable conda package yet, see conda-forge/gap-feedstock#68. However, better fail with a good error message then some random warning during build.

It would be nice if in the future breaking package updates would only happen if conda provides a suitable package.

📝 Checklist

  • I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@dimpase
Copy link
Member

dimpase commented Mar 26, 2023

GAP 4.12.2 is out for quite a while. And the breakage is in a beta so far.

@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 7d8c93e

@tobiasdiez
Copy link
Contributor Author

Thanks for the review, and the fix upstream!

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (c00e6c2) 88.62% compared to head (7d8c93e) 88.60%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35351      +/-   ##
===========================================
- Coverage    88.62%   88.60%   -0.03%     
===========================================
  Files         2148     2148              
  Lines       398855   398855              
===========================================
- Hits        353480   353387      -93     
- Misses       45375    45468      +93     

see 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants