-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pinnings on R-base #3200
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This will of course require a migration beforehand, which I presume is done elsewhere (not sure how that's orchestrated on conda-forge). |
If you want to start a migration take a look at #1513. However, the bot should've picked this one up automatically. Not sure what is going on here. |
@ocefpaf my knowledge could be quite out of date, but r_base doesn't have a compatibility specification in either the meta.yaml as a run_exports or in the pinning conda_build_config. All of the r migrations in the past have been started by hand. I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties. edit: it does have a min/max pin in the conda-build-config. |
to be honest, I think that the r-base recipe may need a bit of touchups in light of the challenges encountered in conda-forge/r-base-feedstock#213 that PR seems to resolve some important issues, but it seems like the maintainers haven't had time to provide feedback or the cleanup necessary. I would be cautious in starting a migration for r-base in light of the lack of comments on that PR from the r-base maintainers |
Now that conda-forge/r-base-feedstock#213 has been merged in, shall we consider again moving forward with a migration? |
This reverts commit 76d062c.
Is there any interest in waiting for conda-forge/r-base-feedstock#210 |
No need to wait from my side. This migration is needed for ~3000 package updates over on Bioconda and we don't build for Windows. |
This looks good to me. Thanks @isuruf for adding the migration. |
Sorry for the delay, I didn't see that you were listed as a maintainer in r-base bgruening |
__migrator: | ||
kind: version | ||
migration_number: 1 | ||
bump_number: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the recipe number bumped for the migration to R 4.2? This causes a new R 4.1 version to be uploaded as well, which seems unnecessary, at least to me. It wouldn't really matter for a few recipes, but this is going to upload thousands of essentially duplicate r41 binaries to anaconda.org (the only difference being the build number).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the build number was not bumped, there'll be a new version uploaded because some of the pinnings (like compiler) have changed and there's a different hash than the one when it was last rebuilt. Therefore bumping the build number avoids two packages with R 4.1 with the same build number, but different hashes.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)