Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinnings on R-base #3200

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Update pinnings on R-base #3200

merged 3 commits into from
Sep 28, 2022

Conversation

dpryan79
Copy link
Contributor

@dpryan79 dpryan79 commented Aug 4, 2022

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@dpryan79 dpryan79 requested a review from a team as a code owner August 4, 2022 08:53
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@dpryan79
Copy link
Contributor Author

dpryan79 commented Aug 4, 2022

This will of course require a migration beforehand, which I presume is done elsewhere (not sure how that's orchestrated on conda-forge).

@ocefpaf
Copy link
Member

ocefpaf commented Aug 4, 2022

If you want to start a migration take a look at #1513. However, the bot should've picked this one up automatically. Not sure what is going on here.

@CJ-Wright
Copy link
Member

CJ-Wright commented Aug 4, 2022

@ocefpaf my knowledge could be quite out of date, but r_base doesn't have a compatibility specification in either the meta.yaml as a run_exports or in the pinning conda_build_config. All of the r migrations in the past have been started by hand.

I am making this comment solely in my personal capacity and am not conveying any rights to any intellectual property of any third parties.

edit: it does have a min/max pin in the conda-build-config.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Aug 5, 2022

to be honest, I think that the r-base recipe may need a bit of touchups in light of the challenges encountered in conda-forge/r-base-feedstock#213

that PR seems to resolve some important issues, but it seems like the maintainers haven't had time to provide feedback or the cleanup necessary.

I would be cautious in starting a migration for r-base in light of the lack of comments on that PR from the r-base maintainers

@dpryan79
Copy link
Contributor Author

Now that conda-forge/r-base-feedstock#213 has been merged in, shall we consider again moving forward with a migration?

@hmaarrfk
Copy link
Contributor

Is there any interest in waiting for conda-forge/r-base-feedstock#210

@mfansler mfansler mentioned this pull request Sep 11, 2022
@dpryan79
Copy link
Contributor Author

No need to wait from my side. This migration is needed for ~3000 package updates over on Bioconda and we don't build for Windows.

@bgruening
Copy link
Contributor

This looks good to me. Thanks @isuruf for adding the migration.
Can we merge this PR?

@hmaarrfk hmaarrfk merged commit 0a5036b into conda-forge:main Sep 28, 2022
@hmaarrfk
Copy link
Contributor

Sorry for the delay, I didn't see that you were listed as a maintainer in r-base bgruening

__migrator:
kind: version
migration_number: 1
bump_number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the recipe number bumped for the migration to R 4.2? This causes a new R 4.1 version to be uploaded as well, which seems unnecessary, at least to me. It wouldn't really matter for a few recipes, but this is going to upload thousands of essentially duplicate r41 binaries to anaconda.org (the only difference being the build number).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the build number was not bumped, there'll be a new version uploaded because some of the pinnings (like compiler) have changed and there's a different hash than the one when it was last rebuilt. Therefore bumping the build number avoids two packages with R 4.1 with the same build number, but different hashes.

@dpryan79 dpryan79 deleted the patch-1 branch October 12, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants