Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinnings on R-base #3200

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Update pinnings on R-base #3200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
76d062c
Update pinnings on R-base
dpryan79 Aug 4, 2022
3e96811
Revert "Update pinnings on R-base"
isuruf Aug 25, 2022
d86cda9
Add migration
isuruf Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion recipe/conda_build_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,6 @@ ruby:
- 2.5
- 2.6
r_base:
- 4.0
- 4.1
scotch:
- 6.0.9
Expand Down
10 changes: 10 additions & 0 deletions recipe/migrations/r-base42.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
migrator_ts: 1661453785
__migrator:
kind: version
migration_number: 1
bump_number: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the recipe number bumped for the migration to R 4.2? This causes a new R 4.1 version to be uploaded as well, which seems unnecessary, at least to me. It wouldn't really matter for a few recipes, but this is going to upload thousands of essentially duplicate r41 binaries to anaconda.org (the only difference being the build number).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the build number was not bumped, there'll be a new version uploaded because some of the pinnings (like compiler) have changed and there's a different hash than the one when it was last rebuilt. Therefore bumping the build number avoids two packages with R 4.1 with the same build number, but different hashes.

operation: key_add
commit_message: "Rebuild for r-base 4.2"

r_base: # [not win]
- 4.2 # [not win]