Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration for R 4.1 #1513

Merged
merged 4 commits into from
May 21, 2021
Merged

Add migration for R 4.1 #1513

merged 4 commits into from
May 21, 2021

Conversation

xhochy
Copy link
Member

@xhochy xhochy commented May 20, 2021

FYI @conda-forge/r @conda-forge/r-base @conda-forge/core

I would start this tomorrow morning CEST and would babysit it during the day to see if there are any blockers and likely increase the PR rate during the day.

Note that conda-forge/r-base-feedstock#173 is still open but expected to be merged soon.

@xhochy xhochy requested a review from a team as a code owner May 20, 2021 18:47
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more question.

Comment on lines 7 to 8
build_number:
0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe this should be bump_number: 0?

This is what is in the pypy37 migration.

@xhochy
Copy link
Member Author

xhochy commented May 20, 2021

@beckermr Good to go now for tomorrow / later?

@xhochy xhochy merged commit 410c504 into conda-forge:master May 21, 2021
@xhochy xhochy deleted the r410 branch May 21, 2021 07:18
@ocefpaf ocefpaf mentioned this pull request Aug 4, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants