-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request Bot Comment Review for Corporate Contributor #1043
Comments
Added help desk link as part of: #1080 |
It could be a refresh issue that is now resolved due to our updated check logic (which is now faster and doesn't look through all the signature on file). For the last acceptance criteria:
|
@WillsonHG |
I want to keep this open. |
Still need to resolve: "After the contributor verifies their affiliation to their company and the status reports a success, the comment should be edited to show the success comment" |
A good example of how the comment should change from fail to passing is in the logs here https://console.aws.amazon.com/cloudwatch/home?region=us-east-1#logEventViewer:group=/aws/lambda/cla-backend-prod-githubactivity;stream=2020/06/01/%5B$LATEST%5D08b18bc037e14a3f8cc611ba6e39dd2a;start=2020-05-31T20:40:37Z 20:38:58
2020-06-01T20:38:59 DEBUG cla: Updating existing CLA comment for PR: 1644 with body: The committers are authorized under a signed CLA.
20:38:59 2020-06-01T20:38:59 DEBUG cla: EasyCLA App checks pass for PR: 1644 with authors: [('7ea61703407d025d23f21817f94fbf6aca0f1153', 'dependabot[bot]')] 2020-06-01T20:38:59 DEBUG cla: EasyCLA App checks pass for PR: 1644 with authors: [('7ea61703407d025d23f21817f94fbf6aca0f1153', 'dependabot[bot]')] 20:38:59 2020-06-01T20:38:59 DEBUG cla: Creating new CLA status on commit 7ea61703407d025d23f21817f94fbf6aca0f1153: success 2020-06-01T20:38:59 DEBUG cla: Creating new CLA status on commit 7ea61703407d025d23f21817f94fbf6aca0f1153: success 20:39:00 2020-06-01T20:39:00 INFO cla: Successfully posted status on PR 1644: Commit 7ea61703407d025d23f21817f94fbf6aca0f1153 2020-06-01T20:39:00 INFO cla: Successfully posted status on PR 1644: Commit 7ea61703407d025d23f21817f94fbf6aca0f1153 |
Updated logic - see #1532
The last case was missing - now added as part of the Pull Request. |
Pushed to DEV |
Testing blocked due to #1533 |
- Resolved case where previous GitHub failed comment was not being updated Signed-off-by: David Deal <[email protected]>
Summary
Review the bot comment for a user without an ICLA and a company with a CCLA on file in a github pull request.
Background
create a github pull request and be gated by easycla bot.
EasyCLA checks the user and finds them in the Approved list of a company, but the user needs to verify (no ccla signature on file)
Bot posts comment
User verifies with their company.
Cla checks and finds ccla and updates checks in bottom section of PR as success, but does not update the previous failure comment.
Expected behavior
Once the contributor verifies with their company and easycla finds the signature entry, the bot comment should be edited to show success.
The language in the failure comment also needs to be proofed for correct spacing and changed to "Approved List".
Environment
prod
Acceptance Criteria
https://jira.linuxfoundation.org/servicedesk/customer/portal/4
The text was updated successfully, but these errors were encountered: