Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request Bot Comment Review for Corporate Contributor #1043

Closed
2 of 3 tasks
WillsonHG opened this issue May 1, 2020 · 11 comments
Closed
2 of 3 tasks

Pull Request Bot Comment Review for Corporate Contributor #1043

WillsonHG opened this issue May 1, 2020 · 11 comments
Assignees
Labels
02 - Med High Medium High Priority (Higher than Medium; Lower than High) bug Something isn't working HOTFIX_PROD This is a feature that is a hotfix for the Production Deployment

Comments

@WillsonHG
Copy link
Member

WillsonHG commented May 1, 2020

Summary

Review the bot comment for a user without an ICLA and a company with a CCLA on file in a github pull request.

Background

  1. create a github pull request and be gated by easycla bot.

  2. EasyCLA checks the user and finds them in the Approved list of a company, but the user needs to verify (no ccla signature on file)

  3. Bot posts comment
    image

  4. User verifies with their company.

  5. Cla checks and finds ccla and updates checks in bottom section of PR as success, but does not update the previous failure comment.
    image

Expected behavior

Once the contributor verifies with their company and easycla finds the signature entry, the bot comment should be edited to show success.
image
The language in the failure comment also needs to be proofed for correct spacing and changed to "Approved List".

Environment

prod

Acceptance Criteria

  • The text of the comment needs to be changed to read "[github user] is in the company's Approved List, but they must confirm their affiliation with that company. Start by clicking here, choose "Corporate", select your company from the list, and then confirm your affiliation on the page that appears."
  • In addition to the above text, add a sentence to the end with a link to the service desk. "For further assistance with EasyCLA, please submit a support request ticket." The "please submit a support request ticket." section should link to
    https://jira.linuxfoundation.org/servicedesk/customer/portal/4
  • After the contributor verifies their affiliation to their company and the status reports a success, the comment should be edited to show the success comment
    image
@WillsonHG WillsonHG added bug Something isn't working 02 - Med High Medium High Priority (Higher than Medium; Lower than High) labels May 1, 2020
@dealako dealako self-assigned this May 2, 2020
@dealako
Copy link
Member

dealako commented May 6, 2020

Added help desk link as part of: #1080

dealako added a commit that referenced this issue May 6, 2020
@dealako
Copy link
Member

dealako commented May 7, 2020

It could be a refresh issue that is now resolved due to our updated check logic (which is now faster and doesn't look through all the signature on file).

For the last acceptance criteria:

  1. User is gated in GH - no employee signature on file
  2. User is in the "Approved List" by email/domain/gh user whatever but needs to be affiliated with a company
  3. EasyCLA sends the appropriate status update saying they need to be affiliated with their company
  4. All good
  5. The user goes into contributor console, and affiliates with their company
  6. The logic that refreshes the PR:
    1. Updates the Check
    2. DOES NOT update the comment ----> this is what needs to be updated

@nirupamav
Copy link

nirupamav commented May 14, 2020

@WillsonHG
Since the issue is related #722 Should we reopen this or should we close this ticket

@WillsonHG
Copy link
Member Author

I want to keep this open.

@dealako
Copy link
Member

dealako commented May 15, 2020

Still need to resolve: "After the contributor verifies their affiliation to their company and the status reports a success, the comment should be edited to show the success comment"

@WillsonHG WillsonHG added the HOTFIX_PROD This is a feature that is a hotfix for the Production Deployment label May 29, 2020
@WillsonHG
Copy link
Member Author

A good example of how the comment should change from fail to passing is in the logs here https://console.aws.amazon.com/cloudwatch/home?region=us-east-1#logEventViewer:group=/aws/lambda/cla-backend-prod-githubactivity;stream=2020/06/01/%5B$LATEST%5D08b18bc037e14a3f8cc611ba6e39dd2a;start=2020-05-31T20:40:37Z

20:38:58
2020-06-01T20:38:58 INFO cla: Getting comment body for repository type: github
2020-06-01T20:38:58 INFO cla: Getting comment body for repository type: github

20:38:58
2020-06-01T20:38:58 DEBUG cla: Found previously failed checks - updating CLA comment in PR.
2020-06-01T20:38:58 DEBUG cla: Found previously failed checks - updating CLA comment in PR.

20:38:59
2020-06-01T20:38:59 DEBUG cla: Found matching CLA comment for PR: 1644
2020-06-01T20:38:59 DEBUG cla: Found matching CLA comment for PR: 1644

20:38:59
2020-06-01T20:38:59 DEBUG cla: Updating existing CLA comment for PR: 1644 with body: CLA Check
The committers are authorized under a signed CLA.

  • ✅ dependabot[bot] (7ea61703407d025d23f21817f94fbf6aca0f1153)

2020-06-01T20:38:59 DEBUG cla: Updating existing CLA comment for PR: 1644 with body: CLA Check
The committers are authorized under a signed CLA.
  • ✅ dependabot[bot] (7ea61703407d025d23f21817f94fbf6aca0f1153)


20:38:59
2020-06-01T20:38:59 DEBUG cla: EasyCLA App checks pass for PR: 1644 with authors: [('7ea61703407d025d23f21817f94fbf6aca0f1153', 'dependabot[bot]')]
2020-06-01T20:38:59 DEBUG cla: EasyCLA App checks pass for PR: 1644 with authors: [('7ea61703407d025d23f21817f94fbf6aca0f1153', 'dependabot[bot]')]

20:38:59
2020-06-01T20:38:59 DEBUG cla: Creating new CLA status on commit 7ea61703407d025d23f21817f94fbf6aca0f1153: success
2020-06-01T20:38:59 DEBUG cla: Creating new CLA status on commit 7ea61703407d025d23f21817f94fbf6aca0f1153: success

20:39:00
2020-06-01T20:39:00 INFO cla: Successfully posted status on PR 1644: Commit 7ea61703407d025d23f21817f94fbf6aca0f1153
2020-06-01T20:39:00 INFO cla: Successfully posted status on PR 1644: Commit 7ea61703407d025d23f21817f94fbf6aca0f1153

@WillsonHG
Copy link
Member Author

dealako added a commit that referenced this issue Aug 6, 2020
@dealako
Copy link
Member

dealako commented Aug 6, 2020

Updated logic - see #1532

  • Resolved case where previous GitHub failed comment was not being updated - added logic to identify previous comment with 'is missing the User's ID'. So, now we have three cases that we update previously failed checks:
  1. 'not authorized'
  2. 'must confirm their affiliation'
  3. 'is missing the User'

The last case was missing - now added as part of the Pull Request.

@dealako
Copy link
Member

dealako commented Aug 6, 2020

Pushed to DEV

@nirupamav
Copy link

Testing blocked due to #1533

@nirupamav
Copy link

When contributor is authorized and contributor confirms affiliation with the company. Also contributor userid exists in EasyCLA DB
image.png

When contributor is authorized and contributor confirms affiliation with the company. Also contributor userid does not exist in EasyCLA DB

image.png

image.png

image.png

wanyaland pushed a commit to wanyaland/easycla that referenced this issue Aug 18, 2020
- Resolved case where previous GitHub failed comment was not being updated

Signed-off-by: David Deal <[email protected]>
@dealako dealako closed this as completed Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 - Med High Medium High Priority (Higher than Medium; Lower than High) bug Something isn't working HOTFIX_PROD This is a feature that is a hotfix for the Production Deployment
Projects
None yet
Development

No branches or pull requests

3 participants