Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 - CLA Check will pass but status in Github is still shown as CLA NOT SIGNED when contributor approved by githuborg contributes to the project #1498

Closed
nirupamav opened this issue Jul 30, 2020 · 8 comments
Closed

V2 - CLA Check will pass but status in Github is still shown as CLA NOT SIGNED when contributor approved by githuborg contributes to the project #1498

nirupamav opened this issue Jul 30, 2020 · 8 comments
Assignees
@dealako
Labels
01 - High High Priority Contributor Console for V2 Features or Bug Fixes for the Contributor Console v2 v2

Comments

@nirupamav
Copy link

Prerequisite

  1. Create a CLA group with CCLA enabled
  2. Add github repository for the CLA group
  3. Generate template
  4. Company should have signed CLA for the project
  5. Github org should be added as the approval list
  6. Contributor should be invited and the contributor should accept invitation and join the github org(I assigned member role as well as tried with making the contributor owner)

Steps to Follow

  1. Login to Github as individual contributor
  2. Navigate to the repository used in prerequisite
  3. Create PR
  4. CLA check fails
  5. Click on CLA NOT SIGNED
  6. Contributor is redirected to Contributor Console
  7. Click on Proceed as a Corporate Contributor
  8. Search and Select the Company
  9. Click Proceed
  10. Contributor is redirected to Request Authorization instead getting acknowledged
    image.png

image.png
@nirupamav nirupamav added 01 - High High Priority Contributor Console for V2 Features or Bug Fixes for the Contributor Console v2 v2 labels Jul 30, 2020
@nirupamav nirupamav added this to the Sprint 4 - July 27-August 10, 2020 milestone Jul 30, 2020
@nirupamav nirupamav mentioned this issue Jul 30, 2020
Closed
@dealako
Copy link
Member

dealako commented Jul 30, 2020

Please ensure you are public.

@nirupamav
Copy link
Author

nirupamav commented Jul 31, 2020 •
edited
Loading

@dealako
For my user I set Organization visibility to public and then the I was acknowledged. However the status in Github is still shown as CLA NO SIGNED
https://github.com/dronecodeproject-px4/px4/pull/5

image

image

image

@nirupamav nirupamav changed the title V2 - Not able to contribute when githuborg is added as the approval list V2 - CLA Check will pass but status in Github is still shown as CLA NOT SIGNED when contributor approved by githuborg contributes to the project Jul 31, 2020
@dealako dealako assigned dealako and unassigned wanyaland and amolsontakke3576 Jul 31, 2020
@dealako
Copy link
Member

dealako commented Jul 31, 2020

Note to self: Scenario Summary:

  • GH Org Approved before
  • Contributor comes in and acknowledges
  • Status is updated, but not comment

@dealako
Copy link
Member

dealako commented Aug 5, 2020 •
edited
Loading

Creating PR for this fix: #1527

We were not checking with the previous comment was:

Screen Shot 2020-08-05 at 4.33.17 PM.png

Added clause to Python code to identify a previous comment in this format.

dealako added a commit that referenced this issue Aug 5, 2020
@dealako
Merge pull request #1527 from dealako/bug/1498-cla-check-pass-comment…
389964b 
…-not-updated

[#1498] Update GitHub Status Check
@dealako
Copy link
Member

dealako commented Aug 5, 2020

Deploying attempt to fix to DEV

@dealako
Copy link
Member

dealako commented Aug 5, 2020

This issue appears to be resolved.

Before authorization (previously on GH Org approval list, but not affiliated with an org):
Screen Shot 2020-08-05 at 4.53.57 PM.png
After affiliation:
Screen Shot 2020-08-05 at 4.54.06 PM.png

@dealako
Copy link
Member

dealako commented Aug 5, 2020

@nirupamav @WillsonHG this should be resolved now

@nirupamav
Copy link
Author

nirupamav commented Aug 6, 2020 •
edited
Loading

Verified and observed that the issue fixed in both V1 and V2

V2
Scenario - When employee has to sign CLA
image

image

Scenario - When employee need not sign CLA
image

image

V1
Scenario - When employee has to sign CLA
image

image

Scenario - When employee need not sign CLA
image

image

@dealako dealako closed this as completed Aug 6, 2020
dealako added a commit that referenced this issue Aug 6, 2020
@dealako
Merge pull request #1532 from dealako/bug/github-comment-update-missi…
4c7d025 
…ng-user

[#1043,#1498] CLA Check Comment Update
wanyaland pushed a commit to wanyaland/easycla that referenced this issue Aug 18, 2020
@dealako @wanyaland
[communitybridge#1498] Update GitHub Status Check
0eacebd 
- Added logic to update the github status when previously needing to affiliate with company
- Updated debug logic
- Added description and examples to health and version swagger definitions
- Added logo to swagger spec

Signed-off-by: David Deal <[email protected]>
wanyaland pushed a commit to wanyaland/easycla that referenced this issue Aug 18, 2020
@dealako @wanyaland
[communitybridge#1043,communitybridge#1498] CLA Check Comment Update
5da5eb1 
- Resolved case where previous GitHub failed comment was not being updated

Signed-off-by: David Deal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dealako dealako

Labels
01 - High High Priority Contributor Console for V2 Features or Bug Fixes for the Contributor Console v2 v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dealako @wanyaland @amolsontakke3576 @nirupamav