Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 - Not able to view signed projects and not able to sign CLA for projects in Corporate Console due to CORS issue #1533

Closed
nirupamav opened this issue Aug 7, 2020 · 4 comments
Assignees
Labels
01 - High High Priority API Feature or bug relating to the EasyCLA Application Programming Interface (API). Console - Corp Corporate Console Enhancement Tickets (corporate.*.lfcla.com) v1

Comments

@nirupamav
Copy link

  1. Launch Corporate Console
  2. Login as CLA Manager
    Issue1
    3)Click on the exisitng Company
  3. Observed that signed projects are not loaded and observed CORS error in console
    image.png

Issue2
5) Create a Company
6) Click on the Company
7) Click Sign New CLA
8) Select the project
9) Click Submit
10) Observed CORS issue and project name is displayed in UI
11) Click Yes observed CORS issue and project name is displayed in UI
image.png

image.png

@nirupamav nirupamav added API Feature or bug relating to the EasyCLA Application Programming Interface (API). Console - Corp Corporate Console Enhancement Tickets (corporate.*.lfcla.com) v1 labels Aug 7, 2020
@nirupamav nirupamav added this to the Sprint 4 - July 27-August 10, 2020 milestone Aug 7, 2020
@nirupamav nirupamav added the 01 - High High Priority label Aug 7, 2020
@dealako
Copy link
Member

dealako commented Aug 12, 2020

@nirupamav, @wanyaland has resolved this issue with this PR: https://github.com/communitybridge/easycla/pull/1553/files, can you re-check?

@nirupamav
Copy link
Author

nirupamav commented Aug 13, 2020

@dealako @wanyaland
I am still able to reproduce the issue. Cleared cache and tried.
Also observed that CORS error is not displayed in V1 corporate console when accessing the projects signed from V2 corporate console. Issue is observed for only projects signed from V1 corporate console

image.png

image.png

@dealako
Copy link
Member

dealako commented Aug 13, 2020

Issue is:

[ERROR] IndexError: list index out of range
Traceback (most recent call last):
  File "/var/task/wsgi_handler.py", line 110, in handler
    return serverless_wsgi.handle_request(wsgi_app, event, context)
  File "/var/task/serverless_wsgi.py", line 173, in handle_request
    response = Response.from_app(app, environ)
  File "/var/task/werkzeug/wrappers/base_response.py", line 287, in from_app
    return cls(*_run_wsgi_app(app, environ, buffered))
  File "/var/task/werkzeug/test.py", line 1119, in run_wsgi_app
    app_rv = app(environ, start_response)
  File "/var/task/hug/api.py", line 502, in api_auto_instantiate
    return module.__hug_wsgi__(*args, **kwargs)
  File "falcon/api.py", line 274, in falcon.api.API.__call__
    raise
  File "falcon/api.py", line 269, in falcon.api.API.__call__
    responder(req, resp, **params)
  File "/var/task/hug/api.py", line 356, in version_router
    request, response, api_version=api_version, **kwargs
  File "/var/task/hug/interface.py", line 946, in __call__
    raise exception
  File "/var/task/hug/interface.py", line 917, in __call__
    self.call_function(input_parameters), context, request, response, **kwargs
  File "/var/task/hug/interface.py", line 839, in call_function
    return self.interface(**parameters)
  File "/var/task/hug/interface.py", line 129, in __call__
    return __hug_internal_self._function(*args, **kwargs)
  File "/var/task/cla/routes.py", line 762, in get_project
    project["signed_at_foundation_level"] = project_cla_group_list[0].signed_at_foundation

Resolved with PR: #1567

dealako added a commit that referenced this issue Aug 13, 2020
[#1533] Resolved CORS API Issue - Signed at Foundation Flag
@nirupamav
Copy link
Author

Verified that we are able to sign CLA and view signed projects in V1 corporate console
image.png

wanyaland pushed a commit to wanyaland/easycla that referenced this issue Aug 18, 2020
… Flag

- Added conditional around signed at foundation flag logic
- Refactored signed_at_foundation() function

Signed-off-by: David Deal <[email protected]>
@dealako dealako closed this as completed Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - High High Priority API Feature or bug relating to the EasyCLA Application Programming Interface (API). Console - Corp Corporate Console Enhancement Tickets (corporate.*.lfcla.com) v1
Projects
None yet
Development

No branches or pull requests

2 participants