Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dialogs modal #6015

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

parneet-guraya
Copy link
Contributor

Fixes #5778

What changes did you make and why?

  • Made all dialogs non-dismissable (modal) when touched outside it's bounds or back pressed.

@parneet-guraya parneet-guraya changed the title make dialog modal Make dialogs modal Dec 9, 2024
@nicolas-raoul
Copy link
Member

Sorry would you mind rebasing from main and solving the conflicts? Thanks! :-)

@parneet-guraya
Copy link
Contributor Author

Done

Signed-off-by: parneet-guraya <[email protected]>
Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 3 dialogs, seems to work fine.
Thanks!

@nicolas-raoul nicolas-raoul merged commit 9a876fa into commons-app:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tapping outside popup dialog closes it, potentially making user miss it
2 participants