Add cancel button to dialogs with no button #6078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: parneet-guraya <[email protected]>
parneet-guraya
force-pushed
the
fix-dialog
branch
from
72b2160 to
e1885f8
Compare
|
Would you mind posting a screenshot of each? |
|
P.S: Ignore the pixels must be due to conversion to .gif |
nicolas-raoul
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6076
What changes did you make and why?
Added a
cancelbutton to dialogs which didn't have any button because dialogs are modal (non dismissable).Also, I have made dialogs modal which were missed earlier (my IDE had some filter applied so missed some) in this PR Make dialogs modal #6015