Tapping outside popup dialog closes it, potentially making user miss it

[nicolas-raoul]

... especially when uploading many pictures.

I would suggest making such dialogs modal.

screen-20240720-142542.2.mp4

[parneet-guraya]

Could you confirm this again? I tried this by making the dialog show indefinitely (by disabling the code that dismisses it on showLoading(false) event) and on tapping outside or pressing back doesn't dismiss the dialog. I tried in this very same screen.

Record_2024-12-08-05-28-59.mp4

Any chance you're talking about that dialogs should be not cancelable anywhere in the app?

[nicolas-raoul]

This is about this dialog seen in the screencast above:

[parneet-guraya]

Got it!

So, in the API that we use to build these dialogs we have this setCancelable(boolean) which affect both touching outside it's bounds as well as back press meaning if set false it wouldn't let user dismiss the dialog upon back press as well, which we don't intend right? I just want to confirm this because if we want to disable the touch outside part only then we may have to use something else.

So, we have two options:

• use the above setCancelable(boolean (disabling both outside touches & back press) and rely on the buttons that dialogs have.
• as stated above, have some way out to only block outside touch and not block back press events.

Also, I think both touching outside & back press disable would make sense only in loading dialogs

[nicolas-raoul]

There is a "No" button so I would say disabling Back is OK if easier to implement/maintain. 🙂