Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for es_ES #48

Closed
wants to merge 2 commits into from
Closed

Conversation

juanramirez
Copy link
Contributor

Added translations for es_ES (Spanish castilian)

@norberttech
Copy link
Member

@juanramirez thanks! Could you please rebase your branch against current master? There are some conflicts right now.

@juanramirez
Copy link
Contributor Author

Of course, I already saw it.
I also added translations for collections :)

@norberttech
Copy link
Member

@juanramirez thanks! Can you also please take a look at #26 ? There was a problem with missing suffix in translation keys, do you think es_ES locale has similar problem or maybe current translations make perfect sense?

@juanramirez
Copy link
Contributor Author

Well, I also though on it, current ones make sense but they don't feel very natural.
I wanted to translate date differences by something like "hace X segundos" (for the past) and "en X segundos" (for the future), and I realized I couldn't.
I'll take a look.

@norberttech
Copy link
Member

Yea I think @Forst is workin on possibility to use prefix/suffix when required. Also #41 already have implementation for that but still need some tests.

@juanramirez
Copy link
Contributor Author

Added a new pull request for branch in #41, with the tests for PreciseFormatter:
sam002#1

@juanramirez
Copy link
Contributor Author

I'll fix this once #41 is merged :)

@orestes
Copy link

orestes commented Nov 3, 2015

This PR is duplication of #26. I started with the Spanish translations there and pointed a few things that should be improved. I was supposed to wait for #23, but that was closed and the work continued on #41, so I'm waiting for it.

@norberttech
Copy link
Member

#41 was merged

@juanramirez
Copy link
Contributor Author

Hi, @orestes. I didn't see your PR when I did this one. I'm happy with either updating this PR or you updating yours :)

@orestes
Copy link

orestes commented Nov 3, 2015

@norzechowicz it was merged shortly after I commented. Up until then, I had been waiting for it like you asked me to.
@juanramirez no problem. Already updated #26.

@norberttech
Copy link
Member

Closed by #26

@norberttech norberttech closed this Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants