Add russian. Add prefix at format difference.

[sam002]

No description provided.

[norberttech]

@sam002 thanks for contributing! Could you please take a look at #23? As far as I know @Forst was working on that, maybe he can help you here or at least check if what u did is valid?

[norberttech]

Any chance you could write some a tests for PreciseFormatter? Now when we have also prefixes and suffixes it might be hard to understand this code.

[sam002]

In two days. It is generally safe, the error will be at address diff verification.

[sam002]

@norzechowicz, all done. @juanramirez did a tests for formatting.

[norberttech]

@sam002 @juanramirez thanks. Seems it worsk, but there is one thing I dont like in this code. Is the fact that in order to choose which version of "from now" we should use we need to translate "from_now" and if its not translated then we are going to "from_now_prefix". It looks a bit fragile to me.
I was looking at this code and I'm thinkg about making it a bit more like @Forst suggested in #23

Option 1

The idea is to basicaly create one translation string each time. So for example for past time it would be something like:

"compound.ago_prefix" . $value . "compound.ago_suffix"
"compound.from_now_prefix" . $value . "compound.from_now_suffix"

And for languages that dont use prefix we could simply have translations like:

compound:
  ago_prefix: ""
  ago_suffix: "ago"
  from_now_prefix: ""
  from_now_suffix: "from now"

Option 2

Or we can even make it more flexible by making past and future.

Example for suffixes

unit:
  second: "{1} %count% second|[2,Inf] %count% seconds"
  minute: "{1} %count% minute|[2,Inf] %count% minutes"
  hour: "{1} %count% hour|[2,Inf] %count% hours"
  day: "{1} %count% day|[2,Inf] %count% days"
  week: "{1} %count% week|[2,Inf] %count% weeks"
  month: "{1} %count% month|[2,Inf] %count% months"
  year: "{1} %count% year|[2,Inf] %count% years"
past: "%values% ago"
future: "%value% from now"

$this->transChoice("past", ["%value%" => "2 hours, 3 seconds"]);
$this->transChoice("future", ["%value%" => "2 hours, 3 seconds"]);

// "2 hours, 3 seconds ago"
// "2 hours, 3 seconds from now"

Example for prefixes

unit:
  second: "{1} %count% second|[2,Inf] %count% seconds"
  minute: "{1} %count% minute|[2,Inf] %count% minutes"
  hour: "{1} %count% hour|[2,Inf] %count% hours"
  day: "{1} %count% day|[2,Inf] %count% days"
  week: "{1} %count% week|[2,Inf] %count% weeks"
  month: "{1} %count% month|[2,Inf] %count% months"
  year: "{1} %count% year|[2,Inf] %count% years"
past: "xxx %values%"
future: "in %value%"

$this->transChoice("past", ["%value%" => "2 hours, 3 seconds"]);
$this->transChoice("future", ["%value%" => "2 hours, 3 seconds"]);

// "xxx 2 hours, 3 seconds"
// "za 2 hours, 3 seconds"

And we can go even one step further and use Oxford mechanism to create value. This will give us something like 2 hours and 3 seconds ago instead of 2 hours, 3 seconds ago but this can be done in next PR.

[sam002]

Yes, option 2 is the pretty way! I has implemented the past/future formatter and merged repos.
Plz, check: spec/Coduo/PHPHumanizer/DateTime/PreciseFormatterSpec.php Do now this checks?

[norberttech]

No need for $translationKey, 'compound.' . $difference->isPast() ? 'past' : 'future' its enoguh

[norberttech]

@sam002 now it looks much better! Thanks!