-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy edits to documentation for oxford commas #6645
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoffer
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goodbye Oxford commas. I will miss you, mourn you, and remember you.
build now |
Internal build has been started, your results will be available at build completion. |
Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI. |
pklinef
approved these changes
Oct 19, 2021
ricklarsen
pushed a commit
to ricklarsen/ddf
that referenced
this pull request
Oct 19, 2021
4 tasks
ricklarsen
pushed a commit
to ricklarsen/ddf
that referenced
this pull request
Nov 2, 2021
ricklarsen
pushed a commit
that referenced
this pull request
Nov 2, 2021
alexabird
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit 8b164fa.
alexabird
added a commit
that referenced
this pull request
Sep 13, 2024
This reverts commit 8b164fa.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Copy edits to standardize oxford comma usage. (Includes a few fixes to formatting where oxford comma shouldn't be applied)
Who is reviewing it?
@shaundmorris
@jaymcnallie
@sgalla
@rececoffin
Relevant component teams:
@codice/docs
How should this be tested?
review content
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: