Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edits to documentation for oxford commas (#6645) #6648

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

ricklarsen
Copy link

FORWARD PORT of #6645

What does this PR do?

Copy edits to standardize oxford comma usage. (Includes a few fixes to formatting where oxford comma shouldn't be applied)

Who is reviewing it?

@shaundmorris
@jaymcnallie
@sgalla
@rececoffin

Relevant component teams:

@codice/docs

How should this be tested?

review content

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@ricklarsen
Copy link
Author

build now

@cxddfbot
Copy link

cxddfbot commented Nov 1, 2021

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Nov 1, 2021

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@ricklarsen ricklarsen force-pushed the doc-edits-oxford-master branch from d65b778 to 53eef4e Compare November 2, 2021 16:26
@ricklarsen
Copy link
Author

build now

@cxddfbot
Copy link

cxddfbot commented Nov 2, 2021

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Nov 2, 2021

Build FAILURE See the job results in legacy Jenkins UI or in Blue Ocean UI.

@cxddfbot
Copy link

cxddfbot commented Nov 2, 2021

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Nov 2, 2021

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@ricklarsen ricklarsen merged commit fa6eb91 into codice:master Nov 2, 2021
@ricklarsen ricklarsen deleted the doc-edits-oxford-master branch November 2, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants