Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.29.x] Forward ports docs from 2.26 #6811

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

malmgrens4
Copy link
Collaborator

What does this PR do?

Clean up of documentation build
fcbee9f)
#6620

updated documentation template files title fields
a2fa6b6
#6622

added key words and phrases to docs index
ac936ea
#6625

copy edits to fix spacing issues in docs
37eb420
#6639

edits to docs to remove latin abbreviations
186e621
#6640

Copy edits to documentation for oxford commas
fa87289
#6645

Documentation edits to rephrase optional plurals
1884d9a
#6643

Removed future tense from docs content
a8a9976
#6646

added instructions to docs for adding custom user roles
481c7ab
#6652

Updated docs module README
f32e8d1
#6659

Updated dependency list
29e8882
#6656

Who is reviewing it?

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

How should this be tested?

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

(cherry picked from commit 5e8b153)
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2024

CLA assistant check
All committers have signed the CLA.

@malmgrens4 malmgrens4 changed the base branch from master to 2.29.x October 31, 2024 23:48
@malmgrens4
Copy link
Collaborator Author

build now

@cxddfbot
Copy link

cxddfbot commented Nov 1, 2024

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Nov 1, 2024

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@@ -51,7 +51,6 @@ The Catalog Framework decouples clients from service implementations and provide
The Catalog is composed of several components and an API that connects them together.
The ((Catalog API)) is central to ${branding}'s architectural qualities of extensibility and flexibility.
The Catalog API consists of Java interfaces that define Catalog functionality and specify interactions between components.

These interfaces provide the ability for components to interact without a dependency on a particular underlying implementation, thus allowing the possibility of alternate implementations that can maintain interoperability and share developed components.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add back the line breaks

@malmgrens4
Copy link
Collaborator Author

build now

@cxddfbot
Copy link

cxddfbot commented Nov 7, 2024

Internal build has been started, your results will be available at build completion.

@cxddfbot
Copy link

cxddfbot commented Nov 7, 2024

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

@malmgrens4 malmgrens4 merged commit 788d818 into codice:2.29.x Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants