Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker) images: make dockerfiles use node:lts-buster and node:lts-buster-slim for alpine #363

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

timoknapp
Copy link
Contributor

@timoknapp timoknapp commented Jan 5, 2022

I updated the base images again, because the *-slim images do not consist of python, make and g++ whereas the regular buster images does. So this changes do the following:

  • Dockerfile : based on node:lts-buster
  • Dockerfile.alpine : based on node:lts-buster-slim (in here we of course need to temporarily install python, make and g++

This is PR is still related to #357

Whenever we found a fix for the "real" node:alpine image, I will create a new PR :)

  • commit message named according to Contributing Guide
  • npm run codestyle is OK
  • npm test is OK

@timoknapp
Copy link
Contributor Author

@coderaiser I also noticed that you changed the way of how you build cloudcmd using redrun instead of the regular npm run build command. Is that still correct? Otherwise it would be cool if you could have a look to the Docker Github Action and update the build process accordingly. :)

@coderaiser coderaiser merged commit c7371d9 into coderaiser:master Jan 6, 2022
@coderaiser
Copy link
Owner

Thank you 🎉 !

I also noticed that you changed the way of how you build cloudcmd using redrun instead of the regular npm run build command. Is that still correct? Otherwise it would be cool if you could have a look to the Docker Github Action and update the build process accordingly. :)

@timoknapp yes, it's absolutely correct, redrun is faster alternative to npm run. Could you please help me with this :)? I'm working on zenload, mock-import and c4 right now (because c8 has problems), don't want to distract too much.

I recreated the tag.

@timoknapp
Copy link
Contributor Author

Thank you 🎉 !

I also noticed that you changed the way of how you build cloudcmd using redrun instead of the regular npm run build command. Is that still correct? Otherwise it would be cool if you could have a look to the Docker Github Action and update the build process accordingly. :)

@timoknapp yes, it's absolutely correct, redrun is faster alternative to npm run. Could you please help me with this :)? I'm working on zenload, mock-import and c4 right now (because c8 has problems), don't want to distract too much.

I recreated the tag.

Okay cool. I just noticed the new tag, so it should be fixed now.

Unfortunately I am not that confident in those JS libraries, so I wont be of a help here, sorry.

@coderaiser
Copy link
Owner

@timoknapp I'm not asking you to help me with this libraries :).
You can update github actions so it also use redrun, that's a good idea!

@timoknapp
Copy link
Contributor Author

@coderaiser ah okay 😂 I will create a new PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants