Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker) images: make dockerfiles use node:lts-buster and node:lts-buster-slim for alpine #363

Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix(docker) images: make dockerfiles use node:lts-buster and node:lts-buster-slim for alpine #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:lts-buster-slim
FROM node:lts-buster
LABEL maintainer="Coderaiser"

RUN mkdir -p /usr/src/app
Expand Down
10 changes: 5 additions & 5 deletions docker/Dockerfile.alpine
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:alpine
FROM node:lts-buster-slim
LABEL maintainer="Coderaiser"

RUN mkdir -p /usr/src/app
Expand All @@ -8,12 +8,12 @@ COPY package.json /usr/src/app/

RUN npm config set package-lock false && \
npm install --production && \
apk update && \
apk add --no-cache bash make g++ python3 && \
apt update && \
apt install -y make g++ python3 && \
npm i gritty && \
npm cache clean --force && \
apk del make g++ python3 && \
rm -rf /usr/include /tmp/* /var/cache/apk/*
apt remove -y make g++ python3 && \
rm -rf /usr/include /tmp/* /var/cache/apt/*

COPY . /usr/src/app

Expand Down