Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker) images: make dockerfiles use node:lts-buster-slim as base image #362

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Conversation

timoknapp
Copy link
Contributor

@timoknapp timoknapp commented Jan 5, 2022

@coderaiser : It seems that the regular Node docker images cannot be executed on arm architecture anymore. This leads to weird errors while starting the containers.

After some further analysis I found that the issue can be resolved by using a different base docker image (buster-slim) of Node.

For more info read here

I therefore updated the two Dockerfiles to match fix this issue.

This fix will also resolve #357

  • commit message named according to Contributing Guide
  • npm run codestyle is OK
  • npm test is OK

@coderaiser
Copy link
Owner

As I see buster is Debian image. Can we use alpine for alpine image?

@timoknapp
Copy link
Contributor Author

As I see buster is Debian image. Can we use alpine for alpine image?

Yes I tried to use an alpine image for Dockerfile.alpine but with those alpine images I get the same errors as before. I could not find another solution until now.

So either we:

  • get rid of the -alpine Docker releases
  • stick with the releases for now and let both images be based on the buster images.

I try my best to find a working solution for the alpine releases today. In case I fail, we can still decide on how to continue. What do you think?

docker/Dockerfile.alpine Outdated Show resolved Hide resolved
@GitCop
Copy link

GitCop commented Jan 5, 2022

There were the following issues with your Pull Request

  • Commit: 7e6a8a4
  • Commits must be in the following format: %{type}(%{scope}) %{description}

Guidelines are available at https://github.com/coderaiser/cloudcmd/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@coderaiser coderaiser merged commit 75b3513 into coderaiser:master Jan 5, 2022
@coderaiser
Copy link
Owner

coderaiser commented Jan 5, 2022

I think we can apply fix for debian based image, and try to get working alpine image or other as small as alpine, maybe previous version of node.js will work?

@timoknapp
Copy link
Contributor Author

@coderaiser I just found another issue in the pipeline. I will create a new PR soon to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants