4.4.7 Ready code #8675
Merged
4.4.7 Ready code #8675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added by mistake.
docs: add changelog and upgrade for v4.4.7
chore: update admin/prepare-release.php
style: Enable `phpdoc_list_type` fixer
vendor/bin/psalm --set-baseline=psalm-baseline.xml
docs: suppress Psalm errors
The docstring for said method seems to be copied from `assertOK()` and left unchanged.
docs: fix docstring on `TestResponse.assertNotOk()`
docs: Fix typo in Toolbar.php
ErrorException Trying to access array offset on value of type bool
chore: add "config", "revert" to prlint.json
docs: add and update Autoloader descriptions
docs: small improvements to Time
docs: add commnets on Postgre::convertDSN()
fix: Time::difference() DST bug
fix: Model::set() does not accept object
We have code like this:
throw PageNotFoundException::forMethodNotFound($this->method);
and
public static function forMethodNotFound(string $method)
{
return new static(self::lang('HTTP.methodNotFound', [$method]));
}
If Language throws an Exception, the first Exception will be hidden
in the error message.
It is better to use always \A and \z if you try to check a string. Because `$` matches the end of a line, and matches a newline charactor.
Router does decode it, so Filters also should decode.
fix: Language, Router, and Filters
Prep for 4.4.7 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.