Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable phpdoc_array_type #8580

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

paulbalandan
Copy link
Member

Description
Converts T[] to array<T> for arrays with implicit keys.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I appreciate your effort for typing!

@paulbalandan
Copy link
Member Author

I reckon waiting for the coding-standard release with all style changes in will cause conflicts in each of the PRs so I'll be merging this now and retain just one open.

@paulbalandan paulbalandan merged commit 609be52 into codeigniter4:develop Feb 25, 2024
62 checks passed
@paulbalandan paulbalandan deleted the phpdoc_array_type branch February 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants