Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small improvements to Time #8668

Merged
merged 2 commits into from
Mar 28, 2024
Merged

docs: small improvements to Time #8668

merged 2 commits into from
Mar 28, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Mar 27, 2024

Description
See #8659 (comment)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Mar 27, 2024
@kenjis kenjis mentioned this pull request Mar 27, 2024
Closed
3 tasks
datamweb
datamweb approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I read the source for the first time.😂

@kenjis kenjis merged commit 2a63810 into codeigniter4:develop Mar 28, 2024
8 checks passed
@kenjis kenjis deleted the docs-time branch March 28, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @michalsn @datamweb @paulbalandan